From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 121641 invoked by alias); 29 Oct 2019 22:20:54 -0000 Mailing-List: contact elfutils-devel-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Post: List-Help: List-Subscribe: Sender: elfutils-devel-owner@sourceware.org Received: (qmail 120881 invoked by uid 89); 29 Oct 2019 22:20:53 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Checked: by ClamAV 0.100.3 on sourceware.org X-Virus-Found: No X-Spam-SWARE-Status: No, score=-6.7 required=5.0 tests=AWL,BAYES_00,SPF_PASS autolearn=ham version=3.3.1 spammy= X-Spam-Status: No, score=-6.7 required=5.0 tests=AWL,BAYES_00,SPF_PASS autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on sourceware.org X-Spam-Level: X-HELO: gnu.wildebeest.org Received: from wildebeest.demon.nl (HELO gnu.wildebeest.org) (212.238.236.112) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 29 Oct 2019 22:20:52 +0000 Received: from librem (deer0x15.wildebeest.org [172.31.17.151]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by gnu.wildebeest.org (Postfix) with ESMTPSA id 8521F302BB3C; Tue, 29 Oct 2019 23:20:50 +0100 (CET) Received: by librem (Postfix, from userid 1000) id 6C25FC0256; Tue, 29 Oct 2019 23:20:47 +0100 (CET) Date: Tue, 29 Oct 2019 22:20:00 -0000 From: Mark Wielaard To: Omar Sandoval Cc: elfutils-devel@sourceware.org Subject: Re: [PATCH 2/5] libdwfl: only use thread->unwound for initial frame Message-ID: <20191029222047.GA2805@wildebeest.org> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) X-Spam-Flag: NO X-IsSubscribed: yes X-SW-Source: 2019-q4/txt/msg00079.txt.bz2 Hi Omar, On Mon, Oct 07, 2019 at 02:05:36AM -0700, Omar Sandoval wrote: > thread->unwound is only used for set_initial_registers (via > dwfl_thread_state_registers, dwfl_thread_state_register_pc, and a > special case in core_set_initial_registers). At that point, > thread->unwound is always the initial frame, so there's no need to > update it as we unwind the stack. Let's set it to NULL after we do the > initial setup. This simplifies the next change. Very nice cleanup. Pushed to master. Thanks, Mark