From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 3553 invoked by alias); 12 Nov 2019 15:14:51 -0000 Mailing-List: contact elfutils-devel-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Post: List-Help: List-Subscribe: Sender: elfutils-devel-owner@sourceware.org Received: (qmail 3541 invoked by uid 89); 12 Nov 2019 15:14:51 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Checked: by ClamAV 0.100.3 on sourceware.org X-Virus-Found: No X-Spam-SWARE-Status: No, score=-8.4 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_0 autolearn=ham version=3.3.1 spammy=intimate, partners X-Spam-Status: No, score=-8.4 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_0 autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on sourceware.org X-Spam-Level: X-HELO: us-smtp-1.mimecast.com Received: from us-smtp-delivery-1.mimecast.com (HELO us-smtp-1.mimecast.com) (207.211.31.120) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 12 Nov 2019 15:14:50 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1573571688; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=CwC3Ou/sBXT0Jq1uz2u+KCyXRdao7rl63e55ou5x7L8=; b=dIUlFnF3yuCdJOYM7HiYvPMxYnZCGltV5eO6A/pBZlTzCqFGN10T5P73Ica7ZnR3QjoeSD MBBIvB/uDotC8Ru5ox+wMj4RrKfJxSlrkUyAxeLj7W11PJ6YqRO1F+hD4MgThwlQggAP7h /eMUPTNUGQ/ggChP8OrvcaS51YI53/M= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-237-KSZySHObPz6gmb5Pjb0hXw-1; Tue, 12 Nov 2019 10:14:45 -0500 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id C334386A079; Tue, 12 Nov 2019 15:14:44 +0000 (UTC) Received: from redhat.com (ovpn-116-53.phx2.redhat.com [10.3.116.53]) by smtp.corp.redhat.com (Postfix) with ESMTPS id A3B11379D; Tue, 12 Nov 2019 15:14:44 +0000 (UTC) Received: from fche by redhat.com with local (Exim 4.92) (envelope-from ) id 1iUXsR-0004XX-3g; Tue, 12 Nov 2019 10:14:43 -0500 Date: Tue, 12 Nov 2019 15:14:00 -0000 From: "Frank Ch. Eigler" To: Mark Wielaard Cc: elfutils-devel@sourceware.org, amerey@redhat.com Subject: Re: patch 1/2 debuginfod client Message-ID: <20191112151443.GA12710@redhat.com> References: <20191028190438.GC14349@redhat.com> <20191028190602.GD14349@redhat.com> <0bdee1935e9cce5e7ae6804d6d6335cf8ab97b7b.camel@klomp.org> MIME-Version: 1.0 In-Reply-To: <0bdee1935e9cce5e7ae6804d6d6335cf8ab97b7b.camel@klomp.org> User-Agent: Mutt/1.12.0 (2019-05-25) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-MC-Unique: KSZySHObPz6gmb5Pjb0hXw-1 X-Mimecast-Spam-Score: 0 Content-Type: text/plain; charset=WINDOWS-1252 Content-Transfer-Encoding: quoted-printable Content-Disposition: inline X-IsSubscribed: yes X-SW-Source: 2019-q4/txt/msg00122.txt.bz2 Hi - > A few comments on the first (top-level) part, just to make progress. Thanks. > > diff --git a/config/libdebuginfod.pc.in b/config/libdebuginfod.pc.in > No Requires on libelf or libdw? Correct, the debuginfo client code does not call into elfutils. > My only concern is that these might slow down configure when debuginfod > isn't enabled? Can/Should they be moved later after the enable test? It'd be fractions of a second per configure run ... worth worrying about? > > +PKG_PROG_PKG_CONFIG > > +AC_ARG_ENABLE([debuginfod], AC_HELP_STRING([--enable-debuginfod], [Bui= ld debuginfo server and client solib])) > > +AS_IF([test "x$enable_debuginfod" =3D "xyes"], [ > > + AC_DEFINE([ENABLE_DEBUGINFOD],[1],[Build debuginfo-server]) > > + PKG_CHECK_MODULES([libmicrohttpd],[libmicrohttpd >=3D 0.9.33]) > > + PKG_CHECK_MODULES([libcurl],[libcurl >=3D 7.29.0]) > > + PKG_CHECK_MODULES([sqlite3],[sqlite3 >=3D 3.7.17]) > > + PKG_CHECK_MODULES([libarchive],[libarchive >=3D 3.1.2]) > > +], [enable_debuginfod=3D"no"]) > > +AM_CONDITIONAL([DEBUGINFOD],[test "x$enable_debuginfod" =3D "xyes"]) >=20 > Would it be better to enable by default with an error to disable if any > dependencies (and CXX compiler?) aren't found? That's up to you as a policy question. We could keep it this way (manually opt in) for this release to minimize build complications for our non-rpm/intimate distro partners and then switch to opt-out the later. > > OTHER FEATURES > > Deterministic archives by default : ${default_ar_deterministic} > > Native language support : ${USE_NLS} > > + Debuginfo server support : ${enable_debuginfod} >=20 > client and server support? Sure, changed. - FChE