From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 112518 invoked by alias); 14 Nov 2019 11:24:44 -0000 Mailing-List: contact elfutils-devel-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Post: List-Help: List-Subscribe: Sender: elfutils-devel-owner@sourceware.org Received: (qmail 112457 invoked by uid 89); 14 Nov 2019 11:24:42 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Checked: by ClamAV 0.100.3 on sourceware.org X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.4 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.1 spammy= X-Spam-Status: No, score=-3.4 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on sourceware.org X-Spam-Level: X-HELO: us-smtp-delivery-1.mimecast.com Received: from us-smtp-2.mimecast.com (HELO us-smtp-delivery-1.mimecast.com) (205.139.110.61) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 14 Nov 2019 11:24:41 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1573730677; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=kmwWvfQK5kJ1Zorf2U+q3B0bFhFxjuQ83wXRMDfgR3w=; b=cZcSEGokKOr3Kih91KnsFJVv6UjTXIAD29bXQW7lb8VjJMB/6+zbqrXE7J3EcnGyi8plTt 5LAKyhMFFg9jjM/1bgIDYJ8OxqSNihW6XmH6OpEPef8rVzxC9FJXb89iq3hgpUy0HTxOCm 9ck9BDh7NAbMsx9O7IaaojssiHnBzK4= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-188-asiX3fwXNJ-qtP2DUUknfQ-1; Thu, 14 Nov 2019 06:24:33 -0500 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id B55031307F7; Thu, 14 Nov 2019 11:24:32 +0000 (UTC) Received: from redhat.com (ovpn-116-53.phx2.redhat.com [10.3.116.53]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 93B3C44F98; Thu, 14 Nov 2019 11:24:32 +0000 (UTC) Received: from fche by redhat.com with local (Exim 4.92) (envelope-from ) id 1iVDEl-0000t0-0s; Thu, 14 Nov 2019 06:24:31 -0500 Date: Thu, 14 Nov 2019 11:24:00 -0000 From: "Frank Ch. Eigler" To: Mark Wielaard Cc: elfutils-devel@sourceware.org, amerey@redhat.com Subject: Re: patch 1/2 debuginfod client Message-ID: <20191114112430.GA873@redhat.com> References: <20191028190438.GC14349@redhat.com> <20191028190602.GD14349@redhat.com> MIME-Version: 1.0 In-Reply-To: User-Agent: Mutt/1.12.0 (2019-05-25) X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-MC-Unique: asiX3fwXNJ-qtP2DUUknfQ-1 X-Mimecast-Spam-Score: 0 Content-Type: text/plain; charset=WINDOWS-1252 Content-Transfer-Encoding: quoted-printable Content-Disposition: inline X-IsSubscribed: yes X-SW-Source: 2019-q4/txt/msg00131.txt.bz2 Hi - > [...libdw* debuginfod_find_* calls] > But given that they are almost similar, I would suggest to move both > into their own file sharing most of the code to do the dlopen dance. Where? It can't be in the solib. We're talking about sharing, what, two copies of three or four lines of code (the two dlopen attempts?), and a replacement function will not be shorter, all-in. - FChE