From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 49916 invoked by alias); 14 Nov 2019 11:54:48 -0000 Mailing-List: contact elfutils-devel-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Post: List-Help: List-Subscribe: Sender: elfutils-devel-owner@sourceware.org Received: (qmail 49906 invoked by uid 89); 14 Nov 2019 11:54:48 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Checked: by ClamAV 0.100.3 on sourceware.org X-Virus-Found: No X-Spam-SWARE-Status: No, score=-5.9 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_3 autolearn=ham version=3.3.1 spammy=broad X-Spam-Status: No, score=-5.9 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_3 autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on sourceware.org X-Spam-Level: X-HELO: us-smtp-delivery-1.mimecast.com Received: from us-smtp-2.mimecast.com (HELO us-smtp-delivery-1.mimecast.com) (205.139.110.61) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 14 Nov 2019 11:54:47 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1573732485; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=CRLimJqyGFsW3/zcaJ2Kom3ORP6WVC8iLqFtvT70XwY=; b=d8gCQCOwCNdwe1JXMNqtd8gaWIyWA6GAcBgqwpMAygvCP+r5mEW+6mpM7rDtF4fEZ00wm6 /mZ3/w7EDzzYm+KAplUUs81TOPZQf54WNJPh7zqgbU84DIECD3LqzBWTh29nC/UZPoZDzp elAX5xcLv++x3CMSHa9xL7ACaarghqQ= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-152-BNWHUHxXMIeyg7dsJxIA3w-1; Thu, 14 Nov 2019 06:54:41 -0500 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id CF14A9E235C; Thu, 14 Nov 2019 11:54:40 +0000 (UTC) Received: from redhat.com (ovpn-116-53.phx2.redhat.com [10.3.116.53]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 963A7709E4; Thu, 14 Nov 2019 11:54:39 +0000 (UTC) Received: from fche by redhat.com with local (Exim 4.92) (envelope-from ) id 1iVDht-0000ud-Vz; Thu, 14 Nov 2019 06:54:38 -0500 Date: Thu, 14 Nov 2019 11:54:00 -0000 From: "Frank Ch. Eigler" To: Mark Wielaard Cc: elfutils-devel@sourceware.org, amerey@redhat.com Subject: Re: patch 2/2 debuginfod server etc. Message-ID: <20191114115437.GB873@redhat.com> References: <20191028190438.GC14349@redhat.com> <20191028190602.GD14349@redhat.com> <20191028190726.GE14349@redhat.com> MIME-Version: 1.0 In-Reply-To: User-Agent: Mutt/1.12.0 (2019-05-25) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-MC-Unique: BNWHUHxXMIeyg7dsJxIA3w-1 X-Mimecast-Spam-Score: 0 Content-Type: text/plain; charset=WINDOWS-1252 Content-Transfer-Encoding: quoted-printable Content-Disposition: inline X-IsSubscribed: yes X-SW-Source: 2019-q4/txt/msg00132.txt.bz2 Hi - > > +++ b/config/debuginfod.service > > +[Service] > > +Group=3Ddebuginfod > > +#CacheDirectory=3Ddebuginfod > > +ExecStart=3D/usr/bin/debuginfod -d /var/cache/debuginfod/debuginfod.sq= lite -p $DEBUGINFOD_PORT $DEBUGINFOD_VERBOSE $DEBUGINFOD_PATHS > Why is CacheDirectory commented out, I cannot find it anywhere else in > the code. It's a placeholder for a recently added systemd capability (post-rhel7) to avoid hardcoding /var/cache/$SUBDIR paths. > > +++ b/config/debuginfod.sysconfig > > +#DEBUGINFOD_VERBOSE=3D"-v" > > +DEBUGINFOD_PATHS=3D"/usr/lib/debug /usr/bin /usr/sbin /usr/lib /usr/li= b64 /usr/local" >=20 > Should this also include /usr/libexec ? > Isn't /usr/local too broad? Should it also include /opt and/or /srv? Not sure how much it matters. Added a few of them. It's not a problem to include a path that includes non-elf/dwarf non-rpm files; they'll be checked only once. > I am slightly confused about xz-devel vs liblzma. > Could you remind me again what the relation was? > I see we do check for liblzma with pkgconfig in configure.ac. > So I assume the change is correct. Just confused about the naming. Yeah, some distros put the xz libraries into one vs the other name. > > +%if 0%{?rhel} >=3D 8 || 0%{?fedora} >=3D 20 > > +Recommends: elfutils-debuginfod-client > > +%endif > > + >=20 > Should we add %else Requires: elfutils-debuginfod-client? Up to you. Remember, we made the debuginfod client such that it was dlopen'd into libdw(fl) because you didn't want all the debuginfod-client (libcurl) required solibs to be loaded into the program - or into the minimal elfutils installation footprint. This would undo the latter. > Also I think it would be more correct to move the > Recommends/Requires up with the other Requires. (Side note, in > fedora we actually have a separate libs subpackage, in fedora it > should be moved there.) OK. > > +%package debuginfod-client > > +Summary: Libraries and command-line frontend for HTTP ELF/DWARF file s= erver addressed by build-id. > > +License: GPLv2+ >=20 > That should probably be: > GPLv3+ and (GPLv2+ or LGPLv3+) > ^ for the binary, ^ for the library OK. > > +%package debuginfod > > +Summary: HTTP ELF/DWARF file server addressed by build-id. > > +License: GPLv2+ >=20 > GPLv3+ OK. > > +BuildRequires: systemd > > +Requires(post): systemd > > +Requires(preun): systemd > > +Requires(postun): systemd > > +Requires: shadow-utils > > +Requires: /usr/bin/rpm2cpio >=20 > Should that be Requires(pre): shadow-utils? > Because you only need it it the pre-script? Correct. > > -%makeinstall > > +%make_install >=20 > O. Why? What? > Probably fine, just different. Yeah, fedora things. > but I think we should also split this into debuginfod-client > with just the shared library and binary plus manpage. And debuginfod- > client-devel with the header file, pkgconfig and other man-pages. OK, if you don't mind the subrpm proliferation. > Maybe there are some C++ specific warnings we could enable? Will look into it, but wouldn't be surprised if g++ -Wall / -Wextra includes some already. - FChE