From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 86030 invoked by alias); 14 Nov 2019 22:43:09 -0000 Mailing-List: contact elfutils-devel-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Post: List-Help: List-Subscribe: Sender: elfutils-devel-owner@sourceware.org Received: (qmail 86019 invoked by uid 89); 14 Nov 2019 22:43:09 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Checked: by ClamAV 0.100.3 on sourceware.org X-Virus-Found: No X-Spam-SWARE-Status: No, score=-6.6 required=5.0 tests=AWL,BAYES_00,SPF_PASS autolearn=ham version=3.3.1 spammy=58PM, 58pm, HX-Languages-Length:275 X-Spam-Status: No, score=-6.6 required=5.0 tests=AWL,BAYES_00,SPF_PASS autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on sourceware.org X-Spam-Level: X-HELO: gnu.wildebeest.org Received: from wildebeest.demon.nl (HELO gnu.wildebeest.org) (212.238.236.112) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 14 Nov 2019 22:43:08 +0000 Received: from librem (deer0x15.wildebeest.org [172.31.17.151]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by gnu.wildebeest.org (Postfix) with ESMTPSA id 47C263000275; Thu, 14 Nov 2019 23:43:05 +0100 (CET) Received: by librem (Postfix, from userid 1000) id 57CDBC011A; Thu, 14 Nov 2019 23:43:01 +0100 (CET) Date: Thu, 14 Nov 2019 22:43:00 -0000 From: Mark Wielaard To: Andreas Schwab Cc: elfutils-devel@sourceware.org Subject: Re: [PATCH] dwelf_elf_e_machine_string: Clear errno before calling strtol Message-ID: <20191114224301.GA3230@wildebeest.org> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) X-Spam-Flag: NO X-IsSubscribed: yes X-SW-Source: 2019-q4/txt/msg00137.txt.bz2 On Thu, Nov 14, 2019 at 02:54:58PM +0100, Andreas Schwab wrote: > Avoid spurious failure if errno is modified by any other library call in > the test. Looks correct. Pushed to master. Thanks, Mark