From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 64717 invoked by alias); 15 Nov 2019 18:31:41 -0000 Mailing-List: contact elfutils-devel-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Post: List-Help: List-Subscribe: Sender: elfutils-devel-owner@sourceware.org Received: (qmail 64664 invoked by uid 89); 15 Nov 2019 18:31:41 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Checked: by ClamAV 0.100.3 on sourceware.org X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.4 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.1 spammy=WITHIN, spin, SPIN X-Spam-Status: No, score=-3.4 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on sourceware.org X-Spam-Level: X-HELO: us-smtp-1.mimecast.com Received: from us-smtp-delivery-1.mimecast.com (HELO us-smtp-1.mimecast.com) (207.211.31.120) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 15 Nov 2019 18:31:39 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1573842698; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=1BkQWzRRtBNBACMwD96Cqb6+rw/7uR85QOvfEh36vCg=; b=dplNalQxogtcQK6dgBBqpR2PsQlCRSWBInOef1sQV6m/v/DygrHzIBOae8An7BVgok9gku /PrhAeXNL3mojLdg+ZZlTuKCri+VmLtUKQuKe4DvmJ1gRXkU1drw773490clGu7LrOorOi qwAu2NyfNPhEaDmmvPBr4lFtc5n/h0U= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-147-NaBBPiFEOVq5HfPjObDaRQ-1; Fri, 15 Nov 2019 13:31:35 -0500 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 03A961005510; Fri, 15 Nov 2019 18:31:34 +0000 (UTC) Received: from redhat.com (ovpn-116-19.phx2.redhat.com [10.3.116.19]) by smtp.corp.redhat.com (Postfix) with ESMTPS id D88861036C64; Fri, 15 Nov 2019 18:31:33 +0000 (UTC) Received: from fche by redhat.com with local (Exim 4.92) (envelope-from ) id 1iVgNY-0004sN-6N; Fri, 15 Nov 2019 13:31:32 -0500 Date: Fri, 15 Nov 2019 18:31:00 -0000 From: "Frank Ch. Eigler" To: Mark Wielaard Cc: elfutils-devel@sourceware.org, amerey@redhat.com Subject: Re: patch 4 debuginfod: symlink following mode Message-ID: <20191115183132.GB15272@redhat.com> References: <20191028190438.GC14349@redhat.com> <20191028190602.GD14349@redhat.com> <20191028190726.GE14349@redhat.com> <20191104214823.GA17633@redhat.com> <20191107090732.GA19337@redhat.com> <6c66a738f766fc7ab4fc312de3a406285589dbd0.camel@klomp.org> MIME-Version: 1.0 In-Reply-To: <6c66a738f766fc7ab4fc312de3a406285589dbd0.camel@klomp.org> User-Agent: Mutt/1.12.0 (2019-05-25) X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-MC-Unique: NaBBPiFEOVq5HfPjObDaRQ-1 X-Mimecast-Spam-Score: 0 Content-Type: text/plain; charset=WINDOWS-1252 Content-Transfer-Encoding: quoted-printable Content-Disposition: inline X-IsSubscribed: yes X-SW-Source: 2019-q4/txt/msg00148.txt.bz2 Hi - > > In order to support file/rpm archives that are organized via symlink > > trees, add an "-L" option to debuginfod, meaning about the same as for > > find(1) or ls(1): to traverse rather than ignore symlinks. >=20 > Could you give an example of when exactly this is necessary? Because some file/rpm archievs are organized via symlink trees. :-) For example, a build system may have /packages/N/V/R/ARCH/*.rpm files, which are a legion plus /compose/F30/SPIN/ARCH/ directories, which contain=20 symlinks into the former or package archives stored over multiple NFS mounts, whose contents are interleaved via symlinks. > I assume that it isn't really necessary for rpm archives, you probably > don't want to follow any symlinks from an archive that point to > something outside the archive, and you will see all files in the > archive anyway. So following symlinks doesn't seem helpful there. These are not symlinks WITHIN rpms. These are symlinks encountered during filesystem traversal looking for RPMs. > Also why combine symlink following with cross-device searches? > Shouldn't that be separate options? They could be. They seemed to go well together in the cases I've seen and thought about. Would you like another option now? > > -######################################################################= ## > > - > > -# Ensure debuginfod-find can be safely called with no arguments. > > -# Use a relative path to prevent automatic line breaks in the output > > -# due to excessive characters. > > -testrun_compare ../../debuginfod/debuginfod-find < > -Usage: ../../debuginfod/debuginfod-find debuginfo BUILDID > > - or: ../../debuginfod/debuginfod-find executable BUILDID > > - or: ../../debuginfod/debuginfod-find source BUILDID /FILENAME > > -EOF > > - >=20 > This wasn't a very useful test, but did you really intend to remove it? Yes, as more options are added to that tool, the test case is going to be obsoleted every time. This hunk belongs with the interruptibility/progress patch more, I guess. - FChE