From: Omar Sandoval <osandov@osandov.com>
To: elfutils-devel@sourceware.org
Subject: Re: [PATCH] libdwfl: remove broken coalescing logic in dwfl_report_segment()
Date: Thu, 12 Dec 2019 01:26:00 -0000 [thread overview]
Message-ID: <20191212012604.GE204474@vader> (raw)
In-Reply-To: <36faf52bd880a57420004f10ddd66afb70612504.1576027682.git.osandov@fb.com>
On Tue, Dec 10, 2019 at 05:28:19PM -0800, Omar Sandoval wrote:
> From: Omar Sandoval <osandov@fb.com>
>
> dwfl_report_segment() has some logic that detects when a segment is
> contiguous with the previously reported segment, in which case it's
> supposed to coalesce them. However, in this case, it actually returns
> without updating the segment array at all. As far as I can tell, this
> has always been broken. It appears that no one uses the coalescing logic
> anyways, as they pass IDENT as NULL. Let's just get rid of the logic and
> add a test case.
>
> Signed-off-by: Omar Sandoval <osandov@fb.com>
Disregard this patch, I'm going to send it as part of a larger series
shortly.
prev parent reply other threads:[~2019-12-12 1:26 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-11 1:28 Omar Sandoval
2019-12-12 1:26 ` Omar Sandoval [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191212012604.GE204474@vader \
--to=osandov@osandov.com \
--cc=elfutils-devel@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).