From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 52953 invoked by alias); 19 Dec 2019 00:47:46 -0000 Mailing-List: contact elfutils-devel-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Post: List-Help: List-Subscribe: Sender: elfutils-devel-owner@sourceware.org Received: (qmail 52940 invoked by uid 89); 19 Dec 2019 00:47:45 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Checked: by ClamAV 0.100.3 on sourceware.org X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.9 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.1 spammy=proxy X-Spam-Status: No, score=-3.9 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on sourceware.org X-Spam-Level: X-HELO: us-smtp-1.mimecast.com Received: from us-smtp-2.mimecast.com (HELO us-smtp-1.mimecast.com) (205.139.110.61) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 19 Dec 2019 00:47:44 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1576716462; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=DtIkHhIuuV7PGJju6p3sSaoN76MV2IYxAJntQTDcw9E=; b=DUbSGI7mlkA/x33GUp8sZYSxB5iDX6f4w0wuYkTyeObLN0DES4jbAMDal8xE3JW3SYBBqK z4Kyk8Yjd6utV657r2O19zMq4SK0VZ9amc6rUUj6bGKZkhfnUE/1CtU11Wle83IpfYx23A r1fwYbITiZPLuxrexQrlgM7h0LrKqnE= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-2-y4F26U0tPfubCQNNDCip4w-1; Wed, 18 Dec 2019 19:47:39 -0500 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 8554C107ACC4; Thu, 19 Dec 2019 00:47:38 +0000 (UTC) Received: from redhat.com (ovpn-116-36.phx2.redhat.com [10.3.116.36]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 6748E19C5B; Thu, 19 Dec 2019 00:47:38 +0000 (UTC) Received: from fche by redhat.com with local (Exim 4.92) (envelope-from ) id 1ihjyb-000845-4p; Wed, 18 Dec 2019 19:47:37 -0500 Date: Thu, 19 Dec 2019 00:47:00 -0000 From: "Frank Ch. Eigler" To: Mark Wielaard Cc: elfutils-devel@sourceware.org Subject: Re: rfc/patch: debuginfod client $DEBUGINFOD_PROGRESS env var Message-ID: <20191219004737.GB30730@redhat.com> References: <20191204211050.GA11981@redhat.com> <34b18e36d5a94512a27d8e1f65c9230e4803dc7d.camel@klomp.org> <20191212171850.GE13089@redhat.com> <20191213165707.GF13089@redhat.com> MIME-Version: 1.0 In-Reply-To: User-Agent: Mutt/1.12.0 (2019-05-25) X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-MC-Unique: y4F26U0tPfubCQNNDCip4w-1 X-Mimecast-Spam-Score: 0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Content-Disposition: inline X-IsSubscribed: yes X-SW-Source: 2019-q4/txt/msg00278.txt.bz2 Hi - > The code looks good in general, do note that if you rebase/squash to > onto master there is a slight conflict with the curl_res/curlm_res > fixlet. Since GCC10 isn't out yet, just yell if this gives you trouble > and I do/test it for you. I'll figure it out and merge. > [...] > I would add something like: >=20 > /* Make sure there is at least some progress, > try to get at least 1K per progress timeout seconds. */ > curl_easy_setopt(curl, CURLOPT_LOW_SPEED_TIME, 5 * 1024L); > curl_easy_setopt(curl, CURLOPT_LOW_SPEED_LIMIT, progress_timeout); >=20 > The idea being that if we didn't at least get 1K per 5 seconds then the > connection is just so bad that it doesn't make sense to wait for it to > finish, since that will most likely be forever (or feel like it for the > user). The problem with that is that, for a large download such as a kernel, it can take almost a minute to just decompress the kernel-debuginfo rpm far enough to start streaming the vmlinux file. (In the presene of caching somewhere in the http proxy tree, it gets much better the second+ time.) So any small default would be counterproductive to e.g. systemtap users: they'd be forced to override this for basic usage. - FChE