From: "Dmitry V. Levin" <ldv@altlinux.org>
To: Mark Wielaard <mark@klomp.org>
Cc: elfutils-devel@sourceware.org, Omar Sandoval <osandov@fb.com>
Subject: Re: [PATCH] libebl: Don't install libebl.a, libebl.h and remove backends from spec.
Date: Thu, 02 Jan 2020 00:02:00 -0000 [thread overview]
Message-ID: <20200102000245.GB28779@altlinux.org> (raw)
In-Reply-To: <20190829214358.6060-1-mark@klomp.org>
[-- Attachment #1: Type: text/plain, Size: 2180 bytes --]
Hi,
On Thu, Aug 29, 2019 at 11:43:58PM +0200, Mark Wielaard wrote:
> All archive members from libebl.a are now in libdw.a. We don't generate
> separate backend shared libraries anymore. So remove them from the
> elfutils.spec file.
>
> Signed-off-by: Mark Wielaard <mark@klomp.org>
> ---
> config/ChangeLog | 7 +++++++
> config/elfutils.spec.in | 10 ++--------
> libebl/ChangeLog | 5 +++++
> libebl/Makefile.am | 7 ++-----
> 4 files changed, 16 insertions(+), 13 deletions(-)
[...]
> diff --git a/libebl/ChangeLog b/libebl/ChangeLog
> index 6ba3a02b..4da7eeeb 100644
> --- a/libebl/ChangeLog
> +++ b/libebl/ChangeLog
> @@ -1,3 +1,8 @@
> +2019-08-29 Mark Wielaard <mark@klomp.org>
> +
> + * Makefile.am (noinst_LIBRARIES): Add libebl.a.
> + (noinst_HEADERS): Add libebl.h.
(pkginclude_HEADERS): Remove.
> +
> 2019-07-05 Omar Sandoval <osandov@fb.com>
>
> * Makefile.am: Make libebl.a non-PIC by default.
> diff --git a/libebl/Makefile.am b/libebl/Makefile.am
> index 8af84633..d0d475b8 100644
> --- a/libebl/Makefile.am
> +++ b/libebl/Makefile.am
> @@ -34,10 +34,7 @@ endif
> AM_CPPFLAGS += -I$(srcdir)/../libelf -I$(srcdir)/../libdw -I$(srcdir)/../libasm
> VERSION = 1
>
> -lib_LIBRARIES = libebl.a
> -noinst_LIBRARIES = libebl_pic.a
> -
> -pkginclude_HEADERS = libebl.h
> +noinst_LIBRARIES = libebl.a libebl_pic.a
>
> libebl_a_SOURCES = eblopenbackend.c eblclosebackend.c eblreloctypename.c \
> eblsegmenttypename.c eblsectiontypename.c \
> @@ -62,6 +59,6 @@ libebl_a_SOURCES = eblopenbackend.c eblclosebackend.c eblreloctypename.c \
> libebl_pic_a_SOURCES =
> am_libebl_pic_a_OBJECTS = $(libebl_a_SOURCES:.c=.os)
>
> -noinst_HEADERS = libeblP.h ebl-hooks.h
> +noinst_HEADERS = libebl.h libeblP.h ebl-hooks.h
>
> MOSTLYCLEANFILES = $(am_libebl_pic_a_OBJECTS)
After this part of the change libebl.h is no longer installed, but
it's included by libasm.h which is still installed.
This has to be fixed somehow, but I'm not sure whether libebl.h should be
reinstated, libasm.h should stop to include it, or libasm.h should stop
to be installed.
--
ldv
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 801 bytes --]
next prev parent reply other threads:[~2020-01-02 0:02 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-29 21:44 Mark Wielaard
2019-09-10 13:45 ` Mark Wielaard
2020-01-02 0:02 ` Dmitry V. Levin [this message]
2020-01-08 14:09 ` Mark Wielaard
2020-01-08 23:25 ` Dmitry V. Levin
2020-01-09 23:43 ` Mark Wielaard
2020-01-13 11:59 ` Mark Wielaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200102000245.GB28779@altlinux.org \
--to=ldv@altlinux.org \
--cc=elfutils-devel@sourceware.org \
--cc=mark@klomp.org \
--cc=osandov@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).