From: "Frank Ch. Eigler" <fche@redhat.com>
To: Mark Wielaard <mark@klomp.org>
Cc: elfutils-devel@sourceware.org
Subject: Re: patch rfc: debuginfod -Z (generalized archive) support
Date: Fri, 07 Feb 2020 13:57:00 -0000 [thread overview]
Message-ID: <20200207135722.GF6840@redhat.com> (raw)
In-Reply-To: <20200207133000.GO42691@wildebeest.org>
Hi -
> Yes, lets make =CMD optional. But why assume "cat"? Can't you then
> simply use fopen instaed of popen in the code to get the FILE* to pass
> to archive_read_open_FILE? Or even just open and archive_read_open_fd?
One reason: the defer_dtor<>-based auto-closing of these objects is
different. (popens must be closed with pclose not something else.) A
robust auto-closer is needed because of all the exceptions we may
trigger.
- FChE
next prev parent reply other threads:[~2020-02-07 13:57 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-05 20:09 Frank Ch. Eigler
2020-02-07 9:24 ` Mark Wielaard
2020-02-07 11:44 ` Frank Ch. Eigler
2020-02-07 13:30 ` Mark Wielaard
2020-02-07 13:31 ` Frank Ch. Eigler
2020-02-07 13:57 ` Frank Ch. Eigler [this message]
2020-02-07 23:09 ` Mark Wielaard
2020-02-07 23:15 ` Frank Ch. Eigler
2020-02-10 16:15 ` Frank Ch. Eigler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200207135722.GF6840@redhat.com \
--to=fche@redhat.com \
--cc=elfutils-devel@sourceware.org \
--cc=mark@klomp.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).