From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 38856 invoked by alias); 7 Feb 2020 13:57:31 -0000 Mailing-List: contact elfutils-devel-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Post: List-Help: List-Subscribe: Sender: elfutils-devel-owner@sourceware.org Received: (qmail 38846 invoked by uid 89); 7 Feb 2020 13:57:30 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Checked: by ClamAV 0.100.3 on sourceware.org X-Virus-Found: No X-Spam-SWARE-Status: No, score=-4.2 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 spammy=robust X-Spam-Status: No, score=-4.2 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on sourceware.org X-Spam-Level: X-HELO: us-smtp-delivery-1.mimecast.com Received: from us-smtp-1.mimecast.com (HELO us-smtp-delivery-1.mimecast.com) (205.139.110.61) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 07 Feb 2020 13:57:29 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1581083848; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=RuV0pqMEApsWO5SXFmrnXHZiEDRc/tTEQLGxK7YhhC8=; b=GDPC3TbbFsRnm9Z0EX9vjMU8Ah9FtxtByH2SY829mOdtQ2JE2o6UEJzpRdtutxSvieskVW GWwdxwGXigPhW0ldSaFUJuUiz+gUYc6GxYs28MD8Xz28eXBJ9otZfRWI5lqx9KdOv3XmEK d3OOE7Z28p/3ZfQNt9fAJWuxWXYF0Ww= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-280-d9B2oPJ_O2OErAfl0ur44w-1; Fri, 07 Feb 2020 08:57:24 -0500 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id AD701DB61; Fri, 7 Feb 2020 13:57:23 +0000 (UTC) Received: from redhat.com (ovpn-116-36.phx2.redhat.com [10.3.116.36]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 8F5C75DA7E; Fri, 7 Feb 2020 13:57:23 +0000 (UTC) Received: from fche by redhat.com with local (Exim 4.92) (envelope-from ) id 1j048I-00036c-6a; Fri, 07 Feb 2020 08:57:22 -0500 Date: Fri, 07 Feb 2020 13:57:00 -0000 From: "Frank Ch. Eigler" To: Mark Wielaard Cc: elfutils-devel@sourceware.org Subject: Re: patch rfc: debuginfod -Z (generalized archive) support Message-ID: <20200207135722.GF6840@redhat.com> References: <20200205200918.GA1336@redhat.com> <20200207092434.GL42691@wildebeest.org> <20200207114402.GC6840@redhat.com> <20200207133000.GO42691@wildebeest.org> MIME-Version: 1.0 In-Reply-To: <20200207133000.GO42691@wildebeest.org> User-Agent: Mutt/1.12.0 (2019-05-25) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-MC-Unique: d9B2oPJ_O2OErAfl0ur44w-1 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Content-Disposition: inline X-IsSubscribed: yes X-SW-Source: 2020-q1/txt/msg00082.txt Hi - > Yes, lets make =3DCMD optional. But why assume "cat"? Can't you then > simply use fopen instaed of popen in the code to get the FILE* to pass > to archive_read_open_FILE? Or even just open and archive_read_open_fd? One reason: the defer_dtor<>-based auto-closing of these objects is different. (popens must be closed with pclose not something else.) A robust auto-closer is needed because of all the exceptions we may trigger. - FChE