* [PATCH] libdw: Remove duplicate local wildcards from map file.
@ 2020-09-03 13:00 Mark Wielaard
2020-09-03 16:57 ` Dmitry V. Levin
0 siblings, 1 reply; 3+ messages in thread
From: Mark Wielaard @ 2020-09-03 13:00 UTC (permalink / raw)
To: elfutils-devel; +Cc: Mark Wielaard
We only need one local: * entry to capture all private local symbols.
Signed-off-by: Mark Wielaard <mark@klomp.org>
---
libdw/ChangeLog | 8 ++++++++
libdw/libdw.map | 10 ----------
2 files changed, 8 insertions(+), 10 deletions(-)
diff --git a/libdw/ChangeLog b/libdw/ChangeLog
index 796dbfb7..13683ef0 100644
--- a/libdw/ChangeLog
+++ b/libdw/ChangeLog
@@ -1,3 +1,11 @@
+2020-09-03 Mark Wielaard <mark@klomp.org>
+
+ * libdw.map (ELFUTILS_0.126): Remove local wildcard.
+ (ELFUTILS_0.127): Likewise.
+ (ELFUTILS_0.130): Likewise.
+ (ELFUTILS_0.136): Likewise.
+ (ELFUTILS_0.138): Likewise.
+
2020-08-25 Mark Wielaard <mark@klomp.org>
* dwarf_getlocation.c (check_constant_offset): Rename to...
diff --git a/libdw/libdw.map b/libdw/libdw.map
index decac05c..8ab0a2a0 100644
--- a/libdw/libdw.map
+++ b/libdw/libdw.map
@@ -149,8 +149,6 @@ ELFUTILS_0.126 {
global:
dwarf_getelf;
- local:
- *;
} ELFUTILS_0.122;
ELFUTILS_0.127 {
@@ -161,8 +159,6 @@ ELFUTILS_0.127 {
dwfl_report_begin_add;
dwfl_module_address_section;
- local:
- *;
} ELFUTILS_0.126;
ELFUTILS_0.130 {
@@ -172,8 +168,6 @@ ELFUTILS_0.130 {
dwfl_module_build_id;
dwfl_module_report_build_id;
- local:
- *;
} ELFUTILS_0.127;
ELFUTILS_0.136 {
@@ -181,8 +175,6 @@ ELFUTILS_0.136 {
dwfl_addrsegment;
dwfl_report_segment;
- local:
- *;
} ELFUTILS_0.130;
ELFUTILS_0.138 {
@@ -190,8 +182,6 @@ ELFUTILS_0.138 {
# Replaced ELFUTILS_0.130 version, which has bug-compatibility wrapper.
dwfl_module_build_id;
- local:
- *;
} ELFUTILS_0.136;
ELFUTILS_0.142 {
--
2.18.4
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] libdw: Remove duplicate local wildcards from map file.
2020-09-03 13:00 [PATCH] libdw: Remove duplicate local wildcards from map file Mark Wielaard
@ 2020-09-03 16:57 ` Dmitry V. Levin
2020-09-03 19:28 ` Mark Wielaard
0 siblings, 1 reply; 3+ messages in thread
From: Dmitry V. Levin @ 2020-09-03 16:57 UTC (permalink / raw)
To: Mark Wielaard; +Cc: elfutils-devel
On Thu, Sep 03, 2020 at 03:00:36PM +0200, Mark Wielaard wrote:
> We only need one local: * entry to capture all private local symbols.
Yes, the first one (inside ELFUTILS_0.122) is enough.
> Signed-off-by: Mark Wielaard <mark@klomp.org>
> ---
> libdw/ChangeLog | 8 ++++++++
> libdw/libdw.map | 10 ----------
> 2 files changed, 8 insertions(+), 10 deletions(-)
>
> diff --git a/libdw/ChangeLog b/libdw/ChangeLog
> index 796dbfb7..13683ef0 100644
> --- a/libdw/ChangeLog
> +++ b/libdw/ChangeLog
> @@ -1,3 +1,11 @@
> +2020-09-03 Mark Wielaard <mark@klomp.org>
> +
> + * libdw.map (ELFUTILS_0.126): Remove local wildcard.
> + (ELFUTILS_0.127): Likewise.
> + (ELFUTILS_0.130): Likewise.
> + (ELFUTILS_0.136): Likewise.
> + (ELFUTILS_0.138): Likewise.
> +
> 2020-08-25 Mark Wielaard <mark@klomp.org>
>
> * dwarf_getlocation.c (check_constant_offset): Rename to...
> diff --git a/libdw/libdw.map b/libdw/libdw.map
> index decac05c..8ab0a2a0 100644
> --- a/libdw/libdw.map
> +++ b/libdw/libdw.map
> @@ -149,8 +149,6 @@ ELFUTILS_0.126 {
> global:
> dwarf_getelf;
>
> - local:
> - *;
> } ELFUTILS_0.122;
>
> ELFUTILS_0.127 {
> @@ -161,8 +159,6 @@ ELFUTILS_0.127 {
> dwfl_report_begin_add;
> dwfl_module_address_section;
>
> - local:
> - *;
> } ELFUTILS_0.126;
>
> ELFUTILS_0.130 {
> @@ -172,8 +168,6 @@ ELFUTILS_0.130 {
> dwfl_module_build_id;
> dwfl_module_report_build_id;
>
> - local:
> - *;
> } ELFUTILS_0.127;
>
> ELFUTILS_0.136 {
> @@ -181,8 +175,6 @@ ELFUTILS_0.136 {
> dwfl_addrsegment;
> dwfl_report_segment;
>
> - local:
> - *;
> } ELFUTILS_0.130;
>
> ELFUTILS_0.138 {
> @@ -190,8 +182,6 @@ ELFUTILS_0.138 {
> # Replaced ELFUTILS_0.130 version, which has bug-compatibility wrapper.
> dwfl_module_build_id;
>
> - local:
> - *;
> } ELFUTILS_0.136;
>
> ELFUTILS_0.142 {
> --
> 2.18.4
--
ldv
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] libdw: Remove duplicate local wildcards from map file.
2020-09-03 16:57 ` Dmitry V. Levin
@ 2020-09-03 19:28 ` Mark Wielaard
0 siblings, 0 replies; 3+ messages in thread
From: Mark Wielaard @ 2020-09-03 19:28 UTC (permalink / raw)
To: Dmitry V. Levin; +Cc: elfutils-devel
On Thu, Sep 03, 2020 at 07:57:15PM +0300, Dmitry V. Levin wrote:
> On Thu, Sep 03, 2020 at 03:00:36PM +0200, Mark Wielaard wrote:
> > We only need one local: * entry to capture all private local symbols.
>
> Yes, the first one (inside ELFUTILS_0.122) is enough.
Thanks for the review.
Pushed to master.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-09-03 19:28 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-03 13:00 [PATCH] libdw: Remove duplicate local wildcards from map file Mark Wielaard
2020-09-03 16:57 ` Dmitry V. Levin
2020-09-03 19:28 ` Mark Wielaard
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).