From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by sourceware.org (Postfix) with ESMTP id DE0363857C43 for ; Mon, 26 Oct 2020 22:23:02 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org DE0363857C43 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-419-7jKgVqQgObqpR-9sNKg7kw-1; Mon, 26 Oct 2020 18:23:00 -0400 X-MC-Unique: 7jKgVqQgObqpR-9sNKg7kw-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 2FFABA4CD6; Mon, 26 Oct 2020 22:22:59 +0000 (UTC) Received: from redhat.com (ovpn-112-64.phx2.redhat.com [10.3.112.64]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 135191992F; Mon, 26 Oct 2020 22:22:59 +0000 (UTC) Received: from fche by redhat.com with local (Exim 4.94) (envelope-from ) id 1kXAtF-0006YP-IY; Mon, 26 Oct 2020 18:22:57 -0400 Date: Mon, 26 Oct 2020 18:22:57 -0400 From: "Frank Ch. Eigler" To: Mark Wielaard Cc: =?iso-8859-1?Q?=C9rico?= Nogueira , elfutils-devel@sourceware.org Subject: Re: [PATCH] Don't use locale functions when libintl header isn't included. Message-ID: <20201026222257.GB23993@redhat.com> References: MIME-Version: 1.0 In-Reply-To: User-Agent: Mutt/1.12.0 (2019-05-25) X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: elfutils-devel@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Elfutils-devel mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 26 Oct 2020 22:23:04 -0000 Hi - > On Mon, 2020-10-26 at 01:11 -0300, Érico Nogueira via Elfutils-devel wrote: > > debuginfod.cxx used the bindtextdomain() and textdomain() functions > > despite not including any translated output. These functions were also > > used without including the libintl.h header. > > debuginfod doesn't directly use any translated output, but it links > against libeu.a which provides the print_version function, which does > use translated output. So maybe the correct fix is to #include > instead? I think their concern may be that they don't have any libintl.h or related functions in the musl world. - FChE