public inbox for elfutils@sourceware.org
 help / color / mirror / Atom feed
From: "Érico Nogueira" <ericonr@disroot.org>
To: elfutils-devel@sourceware.org
Cc: "Érico Rolim" <erico.erc@gmail.com>
Subject: [PATCH v2] debuginfod.cxx: include libintl.h.
Date: Sun,  1 Nov 2020 21:58:04 -0300	[thread overview]
Message-ID: <20201102005804.25192-1-ericonr@disroot.org> (raw)

From: Érico Rolim <erico.erc@gmail.com>

Uncomment the <libintl.h> include, since textdomain() and
bindtextdomain() functions provided by it are being used.

Signed-off-by: Érico Rolim <erico.erc@gmail.com>
---

This is a follow up to the patch that went the opposite way and removed
the calls to bindtextdomain() and textdomain(); it was decided that
those calls should be kept, so all that's needed here is to actually
include the header.

 debuginfod/debuginfod.cxx | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/debuginfod/debuginfod.cxx b/debuginfod/debuginfod.cxx
index 3085f388..d2a434ee 100644
--- a/debuginfod/debuginfod.cxx
+++ b/debuginfod/debuginfod.cxx
@@ -46,7 +46,7 @@ extern "C" {
 #include <unistd.h>
 #include <stdlib.h>
 #include <error.h>
-// #include <libintl.h> // not until it supports C++ << better
+#include <libintl.h>
 #include <locale.h>
 #include <pthread.h>
 #include <signal.h>
-- 
2.29.0


             reply	other threads:[~2020-11-02  0:58 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-02  0:58 Érico Nogueira [this message]
2020-11-03  0:17 ` Mark Wielaard
2020-11-03  2:44   ` Érico Nogueira
2020-11-03 17:13     ` Mark Wielaard
2020-11-03 17:16       ` Frank Ch. Eigler
2020-11-03 17:34         ` Mark Wielaard
2020-11-05  0:36           ` Frank Ch. Eigler

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201102005804.25192-1-ericonr@disroot.org \
    --to=ericonr@disroot.org \
    --cc=elfutils-devel@sourceware.org \
    --cc=erico.erc@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).