[PATCH v2] debuginfod.cxx: include libintl.h.

[PATCH v2] debuginfod.cxx: include libintl.h.

[Érico Nogueira]

From: Érico Rolim <erico.erc@gmail.com>

Uncomment the <libintl.h> include, since textdomain() and
bindtextdomain() functions provided by it are being used.

Signed-off-by: Érico Rolim <erico.erc@gmail.com>
---

This is a follow up to the patch that went the opposite way and removed
the calls to bindtextdomain() and textdomain(); it was decided that
those calls should be kept, so all that's needed here is to actually
include the header.

 debuginfod/debuginfod.cxx | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/debuginfod/debuginfod.cxx b/debuginfod/debuginfod.cxx
index 3085f388..d2a434ee 100644
--- a/debuginfod/debuginfod.cxx
+++ b/debuginfod/debuginfod.cxx
@@ -46,7 +46,7 @@ extern "C" {
 #include <unistd.h>
 #include <stdlib.h>
 #include <error.h>
-// #include <libintl.h> // not until it supports C++ << better
+#include <libintl.h>
 #include <locale.h>
 #include <pthread.h>
 #include <signal.h>
-- 
2.29.0

Re: [PATCH v2] debuginfod.cxx: include libintl.h.

[Mark Wielaard]

On Sun, Nov 01, 2020 at 09:58:04PM -0300, Érico Nogueira via Elfutils-devel wrote:
> From: Érico Rolim <erico.erc@gmail.com>
> 
> Uncomment the <libintl.h> include, since textdomain() and
> bindtextdomain() functions provided by it are being used.
> 
> Signed-off-by: Érico Rolim <erico.erc@gmail.com>
> ---
> 
> This is a follow up to the patch that went the opposite way and removed
> the calls to bindtextdomain() and textdomain(); it was decided that
> those calls should be kept, so all that's needed here is to actually
> include the header.

Thanks, added a ChangeLog entry and pushed.

Re: [PATCH v2] debuginfod.cxx: include libintl.h.

[Érico Nogueira]

On Mon Nov 2, 2020 at 10:17 PM -03, Mark Wielaard wrote:
> On Sun, Nov 01, 2020 at 09:58:04PM -0300, Érico Nogueira via
> Elfutils-devel wrote:
> > From: Érico Rolim <erico.erc@gmail.com>
> > 
> > Uncomment the <libintl.h> include, since textdomain() and
> > bindtextdomain() functions provided by it are being used.
> > 
> > Signed-off-by: Érico Rolim <erico.erc@gmail.com>
> > ---
> > 
> > This is a follow up to the patch that went the opposite way and removed
> > the calls to bindtextdomain() and textdomain(); it was decided that
> > those calls should be kept, so all that's needed here is to actually
> > include the header.
>
> Thanks, added a ChangeLog entry and pushed.

Sorry for missing these, and thank you for adding them. So, from what I
understand now, the policy is to add ChangeLog entries in all affected
directories and for every commit?

Thanks,
Érico

Re: [PATCH v2] debuginfod.cxx: include libintl.h.

[Mark Wielaard]

On Mon, 2020-11-02 at 23:44 -0300, Érico Nogueira via Elfutils-devel
wrote:
> On Mon Nov 2, 2020 at 10:17 PM -03, Mark Wielaard wrote:
> > Thanks, added a ChangeLog entry and pushed.
> 
> Sorry for missing these, and thank you for adding them. So, from what I
> understand now, the policy is to add ChangeLog entries in all affected
> directories and for every commit?

Yes, and per function/symbol. Basically following how GNU does it:
https://www.gnu.org/prep/standards/html_node/Change-Logs.html
https://www.gnu.org/software/emacs/manual/html_node/emacs/Change-Log-Commands.html
https://www.gnu.org/software/emacs/manual/html_node/emacs/Format-of-ChangeLog.html

But don't take it too seriously. I seem to be the only person left in
the project that loves ChangeLog entries. They really help me review
what was changed. If too many contributors complain we can look at
alternatives.

Cheers,

Mark

Re: [PATCH v2] debuginfod.cxx: include libintl.h.

[Frank Ch. Eigler]

Hi -

> But don't take it too seriously. I seem to be the only person left in
> the project that loves ChangeLog entries. They really help me review
> what was changed. If too many contributors complain we can look at
> alternatives.

YES PLEASE! :-)

As a transition, how about ChangeLog format content in the git commit
messages?

- FChE

Re: [PATCH v2] debuginfod.cxx: include libintl.h.

[Mark Wielaard]

On Tue, 2020-11-03 at 12:16 -0500, Frank Ch. Eigler wrote:
> Hi -
> 
> > But don't take it too seriously. I seem to be the only person left
> > in
> > the project that loves ChangeLog entries. They really help me
> > review
> > what was changed. If too many contributors complain we can look at
> > alternatives.
> 
> YES PLEASE! :-)
> 
> As a transition, how about ChangeLog format content in the git commit
> messages?

You mean as done by GCC? Not have actual ChangeLog files, but add the
ChangeLog entries themselves in the commit message?
https://gcc.gnu.org/codingconventions.html#ChangeLogs

That certainly works for me. We could even steal their git commit/check
scripts to make it easier for people to follow that format.

Cheers,

Mark

Re: [PATCH v2] debuginfod.cxx: include libintl.h.

[Frank Ch. Eigler]

Hi -

> > YES PLEASE! :-)
> > 
> > As a transition, how about ChangeLog format content in the git commit
> > messages?
> 
> You mean as done by GCC? Not have actual ChangeLog files, but add the
> ChangeLog entries themselves in the commit message?
> https://gcc.gnu.org/codingconventions.html#ChangeLogs

Yeah, IMO that would be better than what we have now,
though I prefer the LKML style more.

> That certainly works for me. We could even steal their git commit/check
> scripts to make it easier for people to follow that format.

If you like ... OTOH we've made do without mechanical enforcement so far.

- FChE