From: Mark Wielaard <mark@klomp.org>
To: "Timm Bäder" <tbaeder@redhat.com>
Cc: elfutils-devel@sourceware.org
Subject: Re: [PATCH 01/14] segment_report_module: Get rid of variable-length arrays
Date: Thu, 19 Nov 2020 00:04:47 +0100 [thread overview]
Message-ID: <20201118230447.GB2684@wildebeest.org> (raw)
In-Reply-To: <20201112150412.2137981-2-tbaeder@redhat.com>
Hi Tim,
On Thu, Nov 12, 2020 at 04:03:59PM +0100, Timm Bäder via Elfutils-devel wrote:
> This prevents a jump which is needed in a later patch.
I liked them better when they defined the array size, since it shows
the array size equals the for loop bounds. But the usage does look
nicer now. I added a ChangeLog entry and pushed.
Thanks,
Mark
P.S. sourceware mangles the From header which makes applying patches
with git am somewhat cumbersome. Could you use a different email
address (that doesn't enforce dkim) or use git send-email
--from=<address> to get the From header in the actual email body?
next prev parent reply other threads:[~2020-11-18 23:05 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-12 15:03 Removing gnu99 constructs from elfutils Timm Bäder
2020-11-12 15:03 ` [PATCH 01/14] segment_report_module: Get rid of variable-length arrays Timm Bäder
2020-11-18 23:04 ` Mark Wielaard [this message]
2020-11-12 15:04 ` [PATCH 02/14] segment_report_module: Pull segment_read into file scope Timm Bäder
2020-11-18 23:18 ` Mark Wielaard
2020-11-12 15:04 ` [PATCH 03/14] segment_report_module: Remove nested finish() function Timm Bäder
2020-11-19 11:18 ` Mark Wielaard
2020-11-12 15:04 ` [PATCH 04/14] segment_report_module: Remove nested release_buffer() function Timm Bäder
2020-11-19 11:24 ` Mark Wielaard
2020-11-12 15:04 ` [PATCH 05/14] segment_report_module: Pull finish_portion() info file scope Timm Bäder
2020-11-19 11:48 ` Mark Wielaard
2020-11-12 15:04 ` [PATCH 06/14] segment_report_module: Pull read_portion() into " Timm Bäder
2020-11-12 15:04 ` [PATCH 07/14] segment_report_module: Use a struct for build id information Timm Bäder
2020-11-12 15:04 ` [PATCH 08/14] segment_report_module: Pull consider_notes() into file scope Timm Bäder
2020-11-12 15:04 ` [PATCH 09/14] segment_report_module: Get rid of nested final_read() function Timm Bäder
2020-11-12 15:04 ` [PATCH 10/14] segment_report_module: Use one loop for p32/p64 arrays Timm Bäder
2020-11-12 15:04 ` [PATCH 11/14] segment_report_module: Inline read_phdr() into only caller Timm Bäder
2020-11-12 15:04 ` [PATCH 12/14] segment_report_module: Unify d32/d64 loops Timm Bäder
2020-11-12 15:04 ` [PATCH 13/14] segment_report_module: Inline consider_dyn() into only caller Timm Bäder
2020-11-12 15:04 ` [PATCH 14/14] segment_report_module: Inline consider_phdr() " Timm Bäder
2020-11-12 16:52 ` Navin P
2020-11-13 7:41 ` Timm Bäder
2020-11-13 8:00 ` Navin P
2020-11-13 12:38 ` Removing gnu99 constructs from elfutils Mark Wielaard
2020-11-13 14:09 ` Timm Bäder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201118230447.GB2684@wildebeest.org \
--to=mark@klomp.org \
--cc=elfutils-devel@sourceware.org \
--cc=tbaeder@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).