public inbox for elfutils@sourceware.org
 help / color / mirror / Atom feed
From: Mark Wielaard <mark@klomp.org>
To: Andreas Krebbel <krebbel@linux.ibm.com>
Cc: elfutils-devel@sourceware.org
Subject: Re: [PATCH 1/1] IBM Z: Fix endianess problem in pid_memory_read
Date: Fri, 20 Nov 2020 01:33:14 +0100	[thread overview]
Message-ID: <20201120003314.GD2684@wildebeest.org> (raw)
In-Reply-To: <20201119193224.49532-1-krebbel@linux.ibm.com>

Hi Andreas,

On Thu, Nov 19, 2020 at 08:32:24PM +0100, Andreas Krebbel via Elfutils-devel wrote:
> The cached reads lack the big endian adjustments done in the fallback
> path.

Thanks for finding this. Did you find this by code inspection or by
having a 31bit binary backtrace on a 64bit system fail?

We actually have a testcase for 31-bit-on-64-bit backtrace
(run-backtrace-native-biarch.sh) but the s390x buildbot worker doesn't
support creating 31bit executables, so the testcase is SKIPPED.

I pushed you patch.

Thanks,

Mark


  reply	other threads:[~2020-11-20  0:34 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-19 19:32 Andreas Krebbel
2020-11-20  0:33 ` Mark Wielaard [this message]
2020-11-20  6:20   ` Andreas Krebbel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201120003314.GD2684@wildebeest.org \
    --to=mark@klomp.org \
    --cc=elfutils-devel@sourceware.org \
    --cc=krebbel@linux.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).