From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <mark@klomp.org>
Received: from gnu.wildebeest.org (wildebeest.demon.nl [212.238.236.112])
 by sourceware.org (Postfix) with ESMTPS id 4A58F39D1418
 for <elfutils-devel@sourceware.org>; Fri, 20 Nov 2020 00:34:11 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 4A58F39D1418
Authentication-Results: sourceware.org;
 dmarc=none (p=none dis=none) header.from=klomp.org
Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=mark@klomp.org
Received: from librem (deer0x15.wildebeest.org [172.31.17.151])
 (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by gnu.wildebeest.org (Postfix) with ESMTPSA id 0BBBE30291AB;
 Fri, 20 Nov 2020 01:34:09 +0100 (CET)
Received: by librem (Postfix, from userid 1000)
 id 1F148C3678; Fri, 20 Nov 2020 01:33:14 +0100 (CET)
Date: Fri, 20 Nov 2020 01:33:14 +0100
From: Mark Wielaard <mark@klomp.org>
To: Andreas Krebbel <krebbel@linux.ibm.com>
Cc: elfutils-devel@sourceware.org
Subject: Re: [PATCH 1/1] IBM Z: Fix endianess problem in pid_memory_read
Message-ID: <20201120003314.GD2684@wildebeest.org>
References: <20201119193224.49532-1-krebbel@linux.ibm.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20201119193224.49532-1-krebbel@linux.ibm.com>
User-Agent: Mutt/1.10.1 (2018-07-13)
X-Spam-Status: No, score=-5.4 required=5.0 tests=BAYES_00, JMQ_SPF_NEUTRAL,
 KAM_DMARC_STATUS, SPF_HELO_NONE, SPF_PASS,
 TXREP autolearn=no autolearn_force=no version=3.4.2
X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on
 server2.sourceware.org
X-BeenThere: elfutils-devel@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Elfutils-devel mailing list <elfutils-devel.sourceware.org>
List-Unsubscribe: <https://sourceware.org/mailman/options/elfutils-devel>,
 <mailto:elfutils-devel-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/elfutils-devel/>
List-Help: <mailto:elfutils-devel-request@sourceware.org?subject=help>
List-Subscribe: <https://sourceware.org/mailman/listinfo/elfutils-devel>,
 <mailto:elfutils-devel-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Fri, 20 Nov 2020 00:34:13 -0000

Hi Andreas,

On Thu, Nov 19, 2020 at 08:32:24PM +0100, Andreas Krebbel via Elfutils-devel wrote:
> The cached reads lack the big endian adjustments done in the fallback
> path.

Thanks for finding this. Did you find this by code inspection or by
having a 31bit binary backtrace on a 64bit system fail?

We actually have a testcase for 31-bit-on-64-bit backtrace
(run-backtrace-native-biarch.sh) but the s390x buildbot worker doesn't
support creating 31bit executables, so the testcase is SKIPPED.

I pushed you patch.

Thanks,

Mark