From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from vmicros1.altlinux.org (vmicros1.altlinux.org [194.107.17.57]) by sourceware.org (Postfix) with ESMTP id A4EA13857831 for ; Sun, 6 Dec 2020 12:28:14 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org A4EA13857831 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=altlinux.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=ldv@altlinux.org Received: from mua.local.altlinux.org (mua.local.altlinux.org [192.168.1.14]) by vmicros1.altlinux.org (Postfix) with ESMTP id CB6E072C8B5; Sun, 6 Dec 2020 15:28:13 +0300 (MSK) Received: by mua.local.altlinux.org (Postfix, from userid 508) id BB1C37CC8A1; Sun, 6 Dec 2020 15:28:13 +0300 (MSK) Date: Sun, 6 Dec 2020 15:28:13 +0300 From: "Dmitry V. Levin" To: Mark Wielaard Cc: elfutils-devel@sourceware.org Subject: Re: [PATCH] debuginfod: export DEBUGINFOD_SONAME macro in debuginfod.h Message-ID: <20201206122813.GA27041@altlinux.org> References: <20201130090000.GA30063@altlinux.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-6.5 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: elfutils-devel@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Elfutils-devel mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 06 Dec 2020 12:28:16 -0000 Hi Mark, On Sun, Dec 06, 2020 at 01:06:42PM +0100, Mark Wielaard wrote: > Hi Dmitry, > > On Mon, 2020-11-30 at 09:00 +0000, Dmitry V. Levin wrote: > > Add DEBUGINFOD_SONAME macro to API for use by those of libdebuginfod > > clients that would like to dlopen the library in the same way as > > __libdwfl_debuginfod_init does. > > I can see how this is useful, but shouldn't libdwfl/debuginfod-client.c > then also use this method/new constants? Thanks, I think libdwfl/debuginfod-client.c should use the versioned name only, and it shouldn't fallback to "libdebuginfod.so" as it does now. I'll submit a separate patch to address that. > Don't we need both versioned and versionless names (at least dwfl tries > the versioned one first, then falls back to the unversioned one). I don't think the versioned name should be exported because it changes in every version while clients don't have to be rebuilt that often. > It would be nice to see documentation in > doc/debuginfod_find_debuginfo.3 Yes, it would be nice, agreed. > Finally, I am actually using the Makefile VERSION variable in a > downstream (DTS) to make sure the so name of all libraries is different > from the system one. This is just a minor issue though, and I should > probably upstream a tweak to do this upstream so others can also more > easily use this. Do you suggest to keep the Makefile VERSION variable? It would become an unused variable with the remaining part of the patch applied unless you upstream the tweak you are talking about. -- ldv