public inbox for elfutils@sourceware.org
 help / color / mirror / Atom feed
From: "Dmitry V. Levin" <ldv@altlinux.org>
To: elfutils-devel@sourceware.org
Subject: Re: [PATCH 2/2] Handle SHF_GNU_RETAIN in eu-readelf and eu-elflint.
Date: Wed, 16 Dec 2020 13:49:30 +0300	[thread overview]
Message-ID: <20201216104930.GB27213@altlinux.org> (raw)
In-Reply-To: <20201212223855.30878-2-mark@klomp.org>

On Sat, Dec 12, 2020 at 11:38:55PM +0100, Mark Wielaard wrote:
> readelf -S now shows 'R' when SHF_GNU_RETAIN is set.
> elflint accepts SHF_GNU_RETAIN when set on section in --gnu mode.
> 
> Signed-off-by: Mark Wielaard <mark@klomp.org>
> ---
>  src/ChangeLog               |   5 ++++
>  src/elflint.c               |   3 +++
>  src/readelf.c               |   2 ++
>  tests/ChangeLog             |   7 ++++++
>  tests/Makefile.am           |   2 ++
>  tests/run-retain.sh         |  44 ++++++++++++++++++++++++++++++++++++
>  tests/testfile-retain.o.bz2 | Bin 0 -> 261 bytes
>  7 files changed, 63 insertions(+)
>  create mode 100755 tests/run-retain.sh
>  create mode 100644 tests/testfile-retain.o.bz2

LGTM, thanks,


-- 
ldv

  reply	other threads:[~2020-12-16 10:49 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-12 22:38 [PATCH 1/2] libelf: Sync elf.h from glibc Mark Wielaard
2020-12-12 22:38 ` [PATCH 2/2] Handle SHF_GNU_RETAIN in eu-readelf and eu-elflint Mark Wielaard
2020-12-16 10:49   ` Dmitry V. Levin [this message]
2020-12-16 18:53     ` Mark Wielaard
2020-12-16 10:44 ` [PATCH 1/2] libelf: Sync elf.h from glibc Dmitry V. Levin
2020-12-16 18:52   ` Mark Wielaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201216104930.GB27213@altlinux.org \
    --to=ldv@altlinux.org \
    --cc=elfutils-devel@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).