From: "Dmitry V. Levin" <ldv@altlinux.org>
To: Mark Wielaard <mark@klomp.org>
Cc: elfutils-devel@sourceware.org
Subject: Re: [PATCH 1/2] Split top level .gitignore file
Date: Sun, 20 Dec 2020 18:59:21 +0300 [thread overview]
Message-ID: <20201220155921.GA28443@altlinux.org> (raw)
In-Reply-To: <20201220153736.GA28383@altlinux.org>
On Sun, Dec 20, 2020 at 06:37:36PM +0300, Dmitry V. Levin wrote:
> On Sun, Dec 20, 2020 at 04:28:30PM +0100, Mark Wielaard wrote:
> > Hi Dmitry,
> >
> > On Sun, Dec 20, 2020 at 03:11:19PM +0300, Dmitry V. Levin wrote:
> > > Move subdirectory parts of the top level .gitignore into appropriate
> > > subdirectories. This would be consistent with ChangeLog files,
> > > currently one has to update the top level ChangeLog file when the top
> > > level .gitignore file is changed in a way that affects specific
> > > subdirectories only.
> >
> > Both changes look good to me. The only thing I would double check is
> > the /*.map entry in backends/.gitignore. It obviously comes from the
> > top-level .gitignore. But I don't know why it was there in the first
> > place.
>
> There used to be libebl_*.map files, removed by commit
> 4f937e24dc7ad1820fc7c99a6dd6422657f14666.
>
> I'll remove it from .gitignore in the second commit then.
Apparently, it's the only entry in backends/.gitignore, and it's really
not a good idea to have an empty backends/.gitignore file.
I could do it in the reverse order: the first commit would update
the top level .gitignore, and the second commit would split it.
--
ldv
next prev parent reply other threads:[~2020-12-20 15:59 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-15 23:40 [PATCH] Modernize gettext infrastructure Dmitry V. Levin
2020-12-15 23:46 ` Q: splitting the top level .gitignore file Dmitry V. Levin
2020-12-16 13:44 ` Mark Wielaard
2020-12-20 12:11 ` [PATCH 1/2] Split " Dmitry V. Levin
2020-12-20 15:28 ` Mark Wielaard
2020-12-20 15:37 ` Dmitry V. Levin
2020-12-20 15:59 ` Dmitry V. Levin [this message]
2020-12-20 16:09 ` Mark Wielaard
2020-12-20 12:11 ` [PATCH 2/2] Update .gitignore files Dmitry V. Levin
2020-12-16 14:05 ` [PATCH] Modernize gettext infrastructure Mark Wielaard
2020-12-16 14:59 ` Dmitry V. Levin
2020-12-16 15:10 ` Mark Wielaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201220155921.GA28443@altlinux.org \
--to=ldv@altlinux.org \
--cc=elfutils-devel@sourceware.org \
--cc=mark@klomp.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).