From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from vmicros1.altlinux.org (vmicros1.altlinux.org [194.107.17.57]) by sourceware.org (Postfix) with ESMTP id E7FDA384B821 for ; Sun, 20 Dec 2020 15:59:21 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org E7FDA384B821 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=altlinux.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=ldv@altlinux.org Received: from mua.local.altlinux.org (mua.local.altlinux.org [192.168.1.14]) by vmicros1.altlinux.org (Postfix) with ESMTP id 64EF072C8B5; Sun, 20 Dec 2020 18:59:21 +0300 (MSK) Received: by mua.local.altlinux.org (Postfix, from userid 508) id 4EA5B7CC89E; Sun, 20 Dec 2020 18:59:21 +0300 (MSK) Date: Sun, 20 Dec 2020 18:59:21 +0300 From: "Dmitry V. Levin" To: Mark Wielaard Cc: elfutils-devel@sourceware.org Subject: Re: [PATCH 1/2] Split top level .gitignore file Message-ID: <20201220155921.GA28443@altlinux.org> References: <20201215234032.GA19917@altlinux.org> <20201215234641.GB19917@altlinux.org> <0e33ef20ac4b0ebbd4ef176d197d4931928e1916.camel@klomp.org> <20201220121119.GA26424@altlinux.org> <20201220152830.GA54564@wildebeest.org> <20201220153736.GA28383@altlinux.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201220153736.GA28383@altlinux.org> X-Spam-Status: No, score=-6.0 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: elfutils-devel@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Elfutils-devel mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 20 Dec 2020 15:59:23 -0000 On Sun, Dec 20, 2020 at 06:37:36PM +0300, Dmitry V. Levin wrote: > On Sun, Dec 20, 2020 at 04:28:30PM +0100, Mark Wielaard wrote: > > Hi Dmitry, > > > > On Sun, Dec 20, 2020 at 03:11:19PM +0300, Dmitry V. Levin wrote: > > > Move subdirectory parts of the top level .gitignore into appropriate > > > subdirectories. This would be consistent with ChangeLog files, > > > currently one has to update the top level ChangeLog file when the top > > > level .gitignore file is changed in a way that affects specific > > > subdirectories only. > > > > Both changes look good to me. The only thing I would double check is > > the /*.map entry in backends/.gitignore. It obviously comes from the > > top-level .gitignore. But I don't know why it was there in the first > > place. > > There used to be libebl_*.map files, removed by commit > 4f937e24dc7ad1820fc7c99a6dd6422657f14666. > > I'll remove it from .gitignore in the second commit then. Apparently, it's the only entry in backends/.gitignore, and it's really not a good idea to have an empty backends/.gitignore file. I could do it in the reverse order: the first commit would update the top level .gitignore, and the second commit would split it. -- ldv