From: Mark Wielaard <mark@klomp.org>
To: tbaeder@redhat.com
Cc: elfutils-devel@sourceware.org
Subject: Re: [PATCH 2/4] strip: Pull relocate() info file scope
Date: Thu, 28 Jan 2021 13:50:33 +0100 [thread overview]
Message-ID: <20210128125033.GH8492@wildebeest.org> (raw)
In-Reply-To: <20210108080449.2201310-3-tbaeder@redhat.com>
Hi Timm,
On Fri, Jan 08, 2021 at 09:04:47AM +0100, Timm Bäder via Elfutils-devel wrote:
> Pull relocate() info file scope and get rid of a nested function this
> way. Refactor remove_debug_relocations() to minimize the parameters we
> need to pass to relocate().
OK. The diff makes it slightly hard to see whether things were
moved/updated correctly, but if we missed something I am sure the
buildbots will catch it. I added a ChangeLog entry and pushed.
Cheers,
Mark
next prev parent reply other threads:[~2021-01-28 12:51 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-08 8:04 Remove nested functions from src/strip.c tbaeder
2021-01-08 8:04 ` [PATCH 1/4] strip: Replace nested check_preserved function with loop tbaeder
2021-01-28 12:17 ` Mark Wielaard
2021-01-08 8:04 ` [PATCH 2/4] strip: Pull relocate() info file scope tbaeder
2021-01-28 12:50 ` Mark Wielaard [this message]
2021-01-08 8:04 ` [PATCH 3/4] strip: Pull update_section_size() into " tbaeder
2021-01-28 12:59 ` Mark Wielaard
2021-01-08 8:04 ` [PATCH 4/4] strip: Remove no_symtab_updates() function tbaeder
2021-01-28 13:29 ` Mark Wielaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210128125033.GH8492@wildebeest.org \
--to=mark@klomp.org \
--cc=elfutils-devel@sourceware.org \
--cc=tbaeder@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).