From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gnu.wildebeest.org (wildebeest.demon.nl [212.238.236.112]) by sourceware.org (Postfix) with ESMTPS id 154843865C2D for ; Thu, 28 Jan 2021 12:51:42 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 154843865C2D Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=klomp.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=mark@klomp.org Received: from librem (ip-213-127-53-184.ip.prioritytelecom.net [213.127.53.184]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by gnu.wildebeest.org (Postfix) with ESMTPSA id 137AB30010D9; Thu, 28 Jan 2021 13:51:40 +0100 (CET) Received: by librem (Postfix, from userid 1000) id 4F85EC3C52; Thu, 28 Jan 2021 13:50:33 +0100 (CET) Date: Thu, 28 Jan 2021 13:50:33 +0100 From: Mark Wielaard To: tbaeder@redhat.com Cc: elfutils-devel@sourceware.org Subject: Re: [PATCH 2/4] strip: Pull relocate() info file scope Message-ID: <20210128125033.GH8492@wildebeest.org> References: <20210108080449.2201310-1-tbaeder@redhat.com> <20210108080449.2201310-3-tbaeder@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20210108080449.2201310-3-tbaeder@redhat.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-Spam-Status: No, score=-3.4 required=5.0 tests=BAYES_00, JMQ_SPF_NEUTRAL, KAM_DMARC_STATUS, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=no autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: elfutils-devel@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Elfutils-devel mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 28 Jan 2021 12:51:43 -0000 Hi Timm, On Fri, Jan 08, 2021 at 09:04:47AM +0100, Timm Bäder via Elfutils-devel wrote: > Pull relocate() info file scope and get rid of a nested function this > way. Refactor remove_debug_relocations() to minimize the parameters we > need to pass to relocate(). OK. The diff makes it slightly hard to see whether things were moved/updated correctly, but if we missed something I am sure the buildbots will catch it. I added a ChangeLog entry and pushed. Cheers, Mark