From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <mark@klomp.org>
Received: from gnu.wildebeest.org (wildebeest.demon.nl [212.238.236.112])
 by sourceware.org (Postfix) with ESMTPS id 9E682385783D
 for <elfutils-devel@sourceware.org>; Thu, 28 Jan 2021 21:09:52 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 9E682385783D
Authentication-Results: sourceware.org;
 dmarc=none (p=none dis=none) header.from=klomp.org
Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=mark@klomp.org
Received: from librem (deer0x15.wildebeest.org [172.31.17.151])
 (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by gnu.wildebeest.org (Postfix) with ESMTPSA id A74443000731;
 Thu, 28 Jan 2021 22:09:51 +0100 (CET)
Received: by librem (Postfix, from userid 1000)
 id 394F8C1749; Thu, 28 Jan 2021 22:08:44 +0100 (CET)
Date: Thu, 28 Jan 2021 22:08:44 +0100
From: Mark Wielaard <mark@klomp.org>
To: tbaeder@redhat.com
Cc: elfutils-devel@sourceware.org
Subject: Re: [PATCH 1/2] elf-from-memory: Restructure code to get rid of
 nested handle_segment()
Message-ID: <20210128210844.GM8492@wildebeest.org>
References: <20210108080956.2201985-1-tbaeder@redhat.com>
 <20210108080956.2201985-2-tbaeder@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20210108080956.2201985-2-tbaeder@redhat.com>
User-Agent: Mutt/1.10.1 (2018-07-13)
X-Spam-Status: No, score=-5.7 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS,
 SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2
X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on
 server2.sourceware.org
X-BeenThere: elfutils-devel@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Elfutils-devel mailing list <elfutils-devel.sourceware.org>
List-Unsubscribe: <https://sourceware.org/mailman/options/elfutils-devel>,
 <mailto:elfutils-devel-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/elfutils-devel/>
List-Help: <mailto:elfutils-devel-request@sourceware.org?subject=help>
List-Subscribe: <https://sourceware.org/mailman/listinfo/elfutils-devel>,
 <mailto:elfutils-devel-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Thu, 28 Jan 2021 21:09:57 -0000

Hi Timm,

On Fri, Jan 08, 2021 at 09:09:55AM +0100, Timm Bäder via Elfutils-devel wrote:
> Use one loop for both 32 and 64  bit case. This allows for only one call
> site of the old handle_segment(), which we can then inline into the for
> loop.

It is a bit hard to see because of the reindenting, but the new code
does indeed do the same as the old code. Added a ChangeLog entry and
pushed.

Thanks,

Mark