From: Mark Wielaard <mark@klomp.org>
To: tbaeder@redhat.com
Cc: elfutils-devel@sourceware.org
Subject: Re: [PATCH 3/5] readelf: Pull left() info file scope
Date: Sat, 30 Jan 2021 21:29:48 +0100 [thread overview]
Message-ID: <20210130202948.GT8492@wildebeest.org> (raw)
In-Reply-To: <20210108081633.2202592-4-tbaeder@redhat.com>
Hi Timm,
On Fri, Jan 08, 2021 at 09:16:31AM +0100, Timm Bäder via Elfutils-devel wrote:
> Get rid of a nested function this way.
I would probably simply inlined that line of code into the two callers
instead of introducing a new function with two arguments. But this
also works. Added a ChangeLog entry and pushed.
Cheers,
Mark
next prev parent reply other threads:[~2021-01-30 20:30 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-08 8:16 Remove nested functions from readelf.c tbaeder
2021-01-08 8:16 ` [PATCH 1/5] readelf: Pull add_dump_section() into file scope tbaeder
2021-01-30 19:55 ` Mark Wielaard
2021-01-08 8:16 ` [PATCH 2/5] readelf: Pull same_set() info " tbaeder
2021-01-30 20:14 ` Mark Wielaard
2021-01-08 8:16 ` [PATCH 3/5] readelf: Pull left() " tbaeder
2021-01-30 20:29 ` Mark Wielaard [this message]
2021-01-08 8:16 ` [PATCH 4/5] readelf: Pull regname() into " tbaeder
2021-01-30 20:47 ` Mark Wielaard
2021-01-08 8:16 ` [PATCH 5/5] readelf: Pull advance_pc() " tbaeder
2021-02-01 14:21 ` Remove nested functions from readelf.c Mark Wielaard
2021-02-02 10:07 ` Timm Bäder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210130202948.GT8492@wildebeest.org \
--to=mark@klomp.org \
--cc=elfutils-devel@sourceware.org \
--cc=tbaeder@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).