From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from vmicros1.altlinux.org (vmicros1.altlinux.org [194.107.17.57]) by sourceware.org (Postfix) with ESMTP id 529843951872 for ; Tue, 2 Feb 2021 03:22:51 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 529843951872 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=altlinux.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=ldv@altlinux.org Received: from mua.local.altlinux.org (mua.local.altlinux.org [192.168.1.14]) by vmicros1.altlinux.org (Postfix) with ESMTP id D11CE72C8B1; Tue, 2 Feb 2021 06:22:50 +0300 (MSK) Received: by mua.local.altlinux.org (Postfix, from userid 508) id BFD2D7CC8A3; Tue, 2 Feb 2021 06:22:50 +0300 (MSK) Date: Tue, 2 Feb 2021 06:22:50 +0300 From: "Dmitry V. Levin" To: =?utf-8?B?w4lyaWNv?= Nogueira Cc: elfutils-devel@sourceware.org, =?utf-8?B?w4lyaWNv?= Rolim Subject: Re: [PATCH v2] backends/ppc_initreg.c: include . Message-ID: <20210202032250.GA30462@altlinux.org> References: <20210202030403.27953-1-ericonr@disroot.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20210202030403.27953-1-ericonr@disroot.org> X-Spam-Status: No, score=-13.2 required=5.0 tests=BAYES_00, GIT_PATCH_0, KAM_DMARC_STATUS, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: elfutils-devel@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Elfutils-devel mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 02 Feb 2021 03:22:52 -0000 On Tue, Feb 02, 2021 at 12:04:03AM -0300, Érico Nogueira via Elfutils-devel wrote: > From: Érico Rolim > > Necessary on musl for struct pt_regs definition, doesn't affect the > build on glibc. > > Signed-off-by: Érico Rolim > --- > > Sending a v2 with the main difference being a slightly different commit > message and signed-off-by line. > > I'm a bit hesitant on this being the correct patch, so I'd ask that you > only merge if you think it makes total sense, otherwise I'd like to sit > on it for a bit. For the record, it has been in use in Void Linux since > the end of 2019. I'm afraid this won't work as is. The reason why glibc doesn't require this change is that its sysdeps/unix/sysv/linux/powerpc/sys/user.h contains #include since the very beginning of this file back in 1998. As you probably know, and are not as compatible as we would like them to be, this is the reason why e.g. elfutils commit 4482d0009a99b1773f2426479b666b08f57af9d5 moved #include before #include . Said that, I think it's safe to include right before on powerpc since in glibc the latter includes the former. > backends/ChangeLog | 4 ++++ > backends/ppc_initreg.c | 1 + > 2 files changed, 5 insertions(+) > > diff --git a/backends/ChangeLog b/backends/ChangeLog > index f22cd57f..eb15c81d 100644 > --- a/backends/ChangeLog > +++ b/backends/ChangeLog > @@ -1,3 +1,7 @@ > +2021-02-01 Érico Nogueira > + > + * ppc_initreg.c: Also include . > + > 2020-12-12 Dmitry V. Levin > > * aarch64_retval.c (aarch64_return_value_location): Fix spelling typo > diff --git a/backends/ppc_initreg.c b/backends/ppc_initreg.c > index 0e0d3599..72cdb860 100644 > --- a/backends/ppc_initreg.c > +++ b/backends/ppc_initreg.c > @@ -32,6 +32,7 @@ > > #include > #if defined(__powerpc__) && defined(__linux__) > +# include > # include > # include > #endif > -- > 2.30.0 -- ldv