From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <ldv@altlinux.org>
Received: from vmicros1.altlinux.org (vmicros1.altlinux.org [194.107.17.57])
 by sourceware.org (Postfix) with ESMTP id 795A9385803C
 for <elfutils-devel@sourceware.org>; Fri,  5 Feb 2021 18:00:06 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 795A9385803C
Authentication-Results: sourceware.org;
 dmarc=none (p=none dis=none) header.from=altlinux.org
Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=ldv@altlinux.org
Received: from mua.local.altlinux.org (mua.local.altlinux.org [192.168.1.14])
 by vmicros1.altlinux.org (Postfix) with ESMTP id EDD9072C8B1;
 Fri,  5 Feb 2021 21:00:05 +0300 (MSK)
Received: by mua.local.altlinux.org (Postfix, from userid 508)
 id DDAFB7CC8A3; Fri,  5 Feb 2021 21:00:05 +0300 (MSK)
Date: Fri, 5 Feb 2021 21:00:05 +0300
From: "Dmitry V. Levin" <ldv@altlinux.org>
To: =?utf-8?B?w4lyaWNv?= Nogueira <ericonr@disroot.org>
Cc: elfutils-devel@sourceware.org,
 =?utf-8?B?w4lyaWNv?= Rolim <erico.erc@gmail.com>
Subject: Re: [PATCH v3] backends/ppc_initreg.c: include <asm/ptrace.h>.
Message-ID: <20210205180005.GD24096@altlinux.org>
References: <20210205175206.26550-1-ericonr@disroot.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20210205175206.26550-1-ericonr@disroot.org>
X-Spam-Status: No, score=-3.2 required=5.0 tests=BAYES_00, GIT_PATCH_0,
 KAM_DMARC_STATUS, SPF_HELO_NONE, SPF_PASS, TXREP,
 UNWANTED_LANGUAGE_BODY autolearn=ham autolearn_force=no version=3.4.2
X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on
 server2.sourceware.org
X-BeenThere: elfutils-devel@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Elfutils-devel mailing list <elfutils-devel.sourceware.org>
List-Unsubscribe: <https://sourceware.org/mailman/options/elfutils-devel>,
 <mailto:elfutils-devel-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/elfutils-devel/>
List-Help: <mailto:elfutils-devel-request@sourceware.org?subject=help>
List-Subscribe: <https://sourceware.org/mailman/listinfo/elfutils-devel>,
 <mailto:elfutils-devel-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Fri, 05 Feb 2021 18:00:09 -0000

On Fri, Feb 05, 2021 at 02:52:06PM -0300, Érico Nogueira via Elfutils-devel wrote:
> From: Érico Rolim <erico.erc@gmail.com>
> 
> Necessary on musl for struct pt_regs definition, doesn't affect the
> build on glibc, since <sys/user.h> includes the same header.
> 
> Signed-off-by: Érico Rolim <erico.erc@gmail.com>
> ---
>  backends/ChangeLog     | 4 ++++
>  backends/ppc_initreg.c | 1 +
>  2 files changed, 5 insertions(+)
> 
> diff --git a/backends/ChangeLog b/backends/ChangeLog
> index f22cd57f..eb15c81d 100644
> --- a/backends/ChangeLog
> +++ b/backends/ChangeLog
> @@ -1,3 +1,7 @@
> +2021-02-01  Érico Nogueira  <ericonr@disroot.org>
> +
> +	* ppc_initreg.c: Also include <asm/ptrace.h>.
> +
>  2020-12-12  Dmitry V. Levin  <ldv@altlinux.org>
>  
>  	* aarch64_retval.c (aarch64_return_value_location): Fix spelling typo
> diff --git a/backends/ppc_initreg.c b/backends/ppc_initreg.c
> index 0e0d3599..e5cca7e1 100644
> --- a/backends/ppc_initreg.c
> +++ b/backends/ppc_initreg.c
> @@ -33,6 +33,7 @@
>  #include <stdlib.h>
>  #if defined(__powerpc__) && defined(__linux__)
>  # include <sys/ptrace.h>
> +# include <asm/ptrace.h>
>  # include <sys/user.h>
>  #endif
>  

LGTM, thanks.


-- 
ldv