From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTP id E110438515D4 for ; Thu, 17 Jun 2021 02:34:16 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org E110438515D4 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-252-yuRI--HsOcyvTI40OYqCBg-1; Wed, 16 Jun 2021 22:34:15 -0400 X-MC-Unique: yuRI--HsOcyvTI40OYqCBg-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 66D4B8015F5 for ; Thu, 17 Jun 2021 02:34:14 +0000 (UTC) Received: from redhat.com (ovpn-112-13.phx2.redhat.com [10.3.112.13]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 4AF185D9CC for ; Thu, 17 Jun 2021 02:34:14 +0000 (UTC) Received: from fche by redhat.com with local (Exim 4.94.2) (envelope-from ) id 1lthrB-0005hz-4e for elfutils-devel@sourceware.org; Wed, 16 Jun 2021 22:34:13 -0400 Date: Wed, 16 Jun 2021 22:34:13 -0400 From: "Frank Ch. Eigler" To: elfutils-devel@sourceware.org Subject: patch rfc - valgrind vs. debuginfod Message-ID: <20210617023413.GP3758@redhat.com> MIME-Version: 1.0 User-Agent: Mutt/1.12.0 (2019-05-25) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Spam-Status: No, score=-12.6 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: elfutils-devel@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Elfutils-devel mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 17 Jun 2021 02:34:18 -0000 Hi - The following patch appears to make valgrind consistently happy, whether distcheck or check runs. It siply arranges to make sure that $VALGRIND_CMD is run without debuginfod client being enabled, even as the $cmd it runs gets the necessary env var set. I don't completely understand the connection to the weird symptoms (32-bit backtraces on 64-bit hosts, missing suppressions?) that we noticed earlier. diff --git a/tests/test-subr.sh b/tests/test-subr.sh index 411e5f288acd..2ea6398c0932 100644 --- a/tests/test-subr.sh +++ b/tests/test-subr.sh @@ -83,7 +83,7 @@ testrun() built_testrun() { LD_LIBRARY_PATH="${built_library_path}${LD_LIBRARY_PATH:+:}$LD_LIBRARY_PATH"\ - $VALGRIND_CMD "$@" + env -u DEBUGINFOD_URLS $VALGRIND_CMD env DEBUGINFOD_URLS="$DEBUGINFOD_URLS" "$@" } installed_testrun() @@ -104,9 +104,9 @@ installed_testrun() if [ "${libdir}" != /usr/lib ] && [ "${libdir}" != /usr/lib64 ]; then LD_LIBRARY_PATH="${libdir}:${libdir}/elfutils\ ${LD_LIBRARY_PATH:+:}$LD_LIBRARY_PATH" \ - $VALGRIND_CMD $program ${1+"$@"} + env -u DEBUGINFOD_URLS $VALGRIND_CMD env DEBUGINFOD_URLS="$DEBUGINFOD_URLS" $program ${1+"$@"} else - $VALGRIND_CMD $program ${1+"$@"} + env -u DEBUGINFOD_URLS $VALGRIND_CMD env DEBUGINFOD_URLS="$DEBUGINFOD_URLS" $program ${1+"$@"} fi }