From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTP id 1C77B3857012 for ; Tue, 20 Jul 2021 18:13:56 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 1C77B3857012 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-248-mknUlWLSO8m5ZSVJrmZw6A-1; Tue, 20 Jul 2021 14:13:54 -0400 X-MC-Unique: mknUlWLSO8m5ZSVJrmZw6A-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id A275B19057A1; Tue, 20 Jul 2021 18:13:53 +0000 (UTC) Received: from redhat.com (ovpn-112-13.phx2.redhat.com [10.3.112.13]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 816225D6A1; Tue, 20 Jul 2021 18:13:53 +0000 (UTC) Received: from fche by redhat.com with local (Exim 4.94.2) (envelope-from ) id 1m5uFb-0002j3-Vf; Tue, 20 Jul 2021 14:13:52 -0400 Date: Tue, 20 Jul 2021 14:13:51 -0400 From: "Frank Ch. Eigler" To: Mark Wielaard Cc: Noah Sanci , elfutils-devel@sourceware.org Subject: Re: [Bug debuginfod/28034] %-escape url characters Message-ID: <20210720181351.GF3315@redhat.com> References: MIME-Version: 1.0 In-Reply-To: User-Agent: Mutt/1.12.0 (2019-05-25) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Spam-Status: No, score=-7.2 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: elfutils-devel@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Elfutils-devel mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 20 Jul 2021 18:13:57 -0000 Hi - > Could you rewrite the commit message to describe what is done in this > patch? (Yeah, Noah's commit text on his branch was corrected.) > [...] > I note that filename is actually the full path component of the URL so > includes slashes ('/'). curl_easy_escape seems to convert these to %2F > (if I am correct). Is this intended? It's harmless. > > +Note: the client should %-escape characters in /SOURCE/FILE that are not shown as "unreserved" in section 2.3 of RFC3986. > > This is a very long line. Could you break it up? > Also, maybe just give the information instead of only a reference. > (The "unreserved" characters are "a"-"z"", "A"-"Z", "0"-"9", "-", ".", "_" and "~") > Also same question as above. slash ('/') is not an unreserved > character, should it be encoded? As we know from the status quo working for a year+, it doesn't matter for "/". But RFC3986 does not give a character class that corresponds exactly to what MUST be encoded, so for documentation purposes this simple SHOULD guidance seems fine. - FChE