From: Saleem Abdulrasool <abdulras@google.com>
To: elfutils-devel@sourceware.org
Subject: [PATCH] debuginfod, elfclassify: remove unnecessary header inclusion
Date: Fri, 20 Aug 2021 18:21:20 +0000 [thread overview]
Message-ID: <20210820182120.2841876-1-abdulras@google.com> (raw)
`error.h`'s inclusion was centralised into the `system.h` header. As
the implementation currently includes `system.h` already, the inclusion
of `error.h` is unnecessary. This prepares for a future portability
change to allow elfutil to build with alternate libc implementations.
Signed-off-by: Saleem Abdulrasool <abdulras@google.com>
---
debuginfod/debuginfod.cxx | 1 -
src/elfclassify.c | 1 -
2 files changed, 2 deletions(-)
diff --git a/debuginfod/debuginfod.cxx b/debuginfod/debuginfod.cxx
index fca07f61..b560fdcb 100644
--- a/debuginfod/debuginfod.cxx
+++ b/debuginfod/debuginfod.cxx
@@ -46,7 +46,6 @@ extern "C" {
#include <unistd.h>
#include <stdlib.h>
-#include <error.h>
#include <libintl.h>
#include <locale.h>
#include <pthread.h>
diff --git a/src/elfclassify.c b/src/elfclassify.c
index fe7eeeed..2f70b29a 100644
--- a/src/elfclassify.c
+++ b/src/elfclassify.c
@@ -19,7 +19,6 @@
#include <system.h>
#include <argp.h>
-#include <error.h>
#include <fcntl.h>
#include <gelf.h>
#include <stdbool.h>
--
2.33.0.rc2.250.ged5fa647cd-goog
next reply other threads:[~2021-08-20 18:21 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-20 18:21 Saleem Abdulrasool [this message]
2021-08-27 15:19 ` Mark Wielaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210820182120.2841876-1-abdulras@google.com \
--to=abdulras@google.com \
--cc=elfutils-devel@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).