From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 026AA3858D28 for ; Mon, 6 Dec 2021 18:41:57 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 026AA3858D28 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-508-BBT9u9iuOqmIcmLHO8RW0Q-1; Mon, 06 Dec 2021 13:41:56 -0500 X-MC-Unique: BBT9u9iuOqmIcmLHO8RW0Q-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 226E984BA70; Mon, 6 Dec 2021 18:41:51 +0000 (UTC) Received: from redhat.com (unknown [10.2.16.5]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 07425794AB; Mon, 6 Dec 2021 18:41:50 +0000 (UTC) Received: from fche by redhat.com with local (Exim 4.94.2) (envelope-from ) id 1muIvt-0001By-Na; Mon, 06 Dec 2021 13:41:49 -0500 Date: Mon, 6 Dec 2021 13:41:49 -0500 From: "Frank Ch. Eigler" To: Mark Wielaard Cc: elfutils-devel@sourceware.org Subject: Re: [PATCH] debuginfod: Clear and reset debuginfod_client winning_headers on reuse Message-ID: <20211206184149.GC31081@redhat.com> References: <20211204215403.277463-1-mark@klomp.org> MIME-Version: 1.0 In-Reply-To: <20211204215403.277463-1-mark@klomp.org> User-Agent: Mutt/1.12.0 (2019-05-25) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Spam-Status: No, score=-6.3 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: elfutils-devel@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Elfutils-devel mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 06 Dec 2021 18:41:59 -0000 Hi - > gcc address sanitizer detected a leak of the debuginfod_client > winning_headers when the handle was reused. Make sure to free and > reset the winning_headers field before reuse. This is good. (Note we're not actually using these winning_headers bits for anything. That was to be part of the "return headers to application" work whose API we were discussing under PR28284. I suspect it'll come to a more thorough motivation & understanding when we try to work out PR28204 - passing file signatures). - FChE