From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 145093858D39 for ; Tue, 18 Jan 2022 16:21:30 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 145093858D39 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-511-N79KotTpP_eKy7HAJu9ezQ-1; Tue, 18 Jan 2022 11:21:21 -0500 X-MC-Unique: N79KotTpP_eKy7HAJu9ezQ-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 947F219611DA; Tue, 18 Jan 2022 16:13:29 +0000 (UTC) Received: from redhat.com (unknown [10.2.16.125]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 7933510A48A9; Tue, 18 Jan 2022 16:13:29 +0000 (UTC) Received: from fche by redhat.com with local (Exim 4.94.2) (envelope-from ) id 1n9r6u-0006cu-Bn; Tue, 18 Jan 2022 11:13:28 -0500 Date: Tue, 18 Jan 2022 11:13:28 -0500 From: "Frank Ch. Eigler" To: =?utf-8?B?0L3QsNCx?= Cc: elfutils-devel@sourceware.org Subject: Re: [PATCH] config: simplify profile.*sh.in Message-ID: <20220118161328.GB21016@redhat.com> References: <20220117162219.fqt7heu4j67fzq35@tarta.nabijaczleweli.xyz> MIME-Version: 1.0 In-Reply-To: <20220117162219.fqt7heu4j67fzq35@tarta.nabijaczleweli.xyz> User-Agent: Mutt/1.12.0 (2019-05-25) X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Spam-Status: No, score=-6.2 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: elfutils-devel@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Elfutils-devel mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 18 Jan 2022 16:21:31 -0000 Hi - > 1. Remove needless profile=@profile@ You mean "prefix=@prefix@". And it's not needless, because @sysconfdir@ often expands to "$prefix/something", which requires a prefix var to be set for evaluation. > 2. Simplify needless sh -c "cat glob 2>/dev/null" > into cat glob 2>/dev/null This is not needless, but I forget the exact details. It probably has to do with the $prefix expansion just above, or perhaps glob non-matching error handling. > 3. Use $( instead of ` under sh I'm neutral on this, assuming it's not a bashism. > 4. Assign to D_U directly and either export it or unset it I'm neutral on this. - FChE