From: Mark Wielaard <mark@klomp.org>
To: elfutils-devel@sourceware.org
Cc: Luca Boccassi <luca.boccassi@gmail.com>,
Luca Boccassi <bluca@debian.org>,
Luca Boccassi <luca.boccassi@microsoft.com>
Subject: [PATCH 2/3] libebl: recognize FDO Packaging Metadata ELF note
Date: Fri, 25 Mar 2022 00:14:37 +0100 [thread overview]
Message-ID: <20220324231438.350551-3-mark@klomp.org> (raw)
In-Reply-To: <20220324231438.350551-1-mark@klomp.org>
From: Luca Boccassi <bluca@debian.org>
As defined on: https://systemd.io/COREDUMP_PACKAGE_METADATA/
this note will be used starting from Fedora 36. Allow
readelf --notes to pretty print it:
Note section [ 3] '.note.package' of 76 bytes at offset 0x2e8:
Owner Data size Type
FDO 57 FDO_PACKAGING_METADATA
Packaging Metadata: {"type":"deb","name":"fsverity-utils","version":"1.3-1"}
Signed-off-by: Luca Boccassi <luca.boccassi@microsoft.com>
---
libebl/ChangeLog | 5 +++++
libebl/eblobjnote.c | 4 ++++
libebl/eblobjnotetypename.c | 3 +++
3 files changed, 12 insertions(+)
diff --git a/libebl/ChangeLog b/libebl/ChangeLog
index da690a40..2e31e75d 100644
--- a/libebl/ChangeLog
+++ b/libebl/ChangeLog
@@ -1,3 +1,8 @@
+2021-12-21 Luca Boccassi <bluca@debian.org>
+
+ * eblobjnote.c (ebl_object_note): Handle NT_FDO_PACKAGING_METADATA.
+ * eblobjnotetypename.c (ebl_object_note_type_name): Likewise.
+
2021-09-06 Dmitry V. Levin <ldv@altlinux.org>
* eblopenbackend.c (openbackend): Remove cast of calloc return value.
diff --git a/libebl/eblobjnote.c b/libebl/eblobjnote.c
index 36efe275..5a7c5c62 100644
--- a/libebl/eblobjnote.c
+++ b/libebl/eblobjnote.c
@@ -288,6 +288,10 @@ ebl_object_note (Ebl *ebl, uint32_t namesz, const char *name, uint32_t type,
if (descsz == 0 && type == NT_VERSION)
return;
+ if (strcmp ("FDO", name) == 0 && type == NT_FDO_PACKAGING_METADATA
+ && descsz > 0 && desc[descsz - 1] == '\0')
+ printf(" Packaging Metadata: %.*s\n", (int) descsz, desc);
+
/* Everything else should have the "GNU" owner name. */
if (strcmp ("GNU", name) != 0)
return;
diff --git a/libebl/eblobjnotetypename.c b/libebl/eblobjnotetypename.c
index 4662906d..473a1f2f 100644
--- a/libebl/eblobjnotetypename.c
+++ b/libebl/eblobjnotetypename.c
@@ -101,6 +101,9 @@ ebl_object_note_type_name (Ebl *ebl, const char *name, uint32_t type,
return buf;
}
+ if (strcmp (name, "FDO") == 0 && type == NT_FDO_PACKAGING_METADATA)
+ return "FDO_PACKAGING_METADATA";
+
if (strcmp (name, "GNU") != 0)
{
/* NT_VERSION is special, all data is in the name. */
--
2.30.2
next prev parent reply other threads:[~2022-03-24 23:15 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-19 0:31 [PATCH] " luca.boccassi
2021-11-21 16:33 ` Mark Wielaard
2021-11-21 19:54 ` Luca Boccassi
2021-11-21 19:43 ` [PATCH v2] " luca.boccassi
2021-11-25 17:02 ` Luca Boccassi
2021-11-30 11:25 ` Mark Wielaard
2021-11-30 12:37 ` Luca Boccassi
2021-11-30 16:23 ` Frank Ch. Eigler
2021-11-30 16:49 ` Florian Weimer
2021-11-30 20:04 ` Mark Wielaard
2021-12-02 15:16 ` Frank Ch. Eigler
2021-12-02 15:44 ` Florian Weimer
2021-12-05 17:36 ` Mark Wielaard
2022-03-24 23:14 ` Mark Wielaard
2022-03-24 23:14 ` [PATCH 1/3] libelf: Sync elf.h from glibc Mark Wielaard
2022-03-24 23:14 ` Mark Wielaard [this message]
2022-03-24 23:14 ` [PATCH 3/3] elflint: Recognize NT_FDO_PACKAGING_METADATA Mark Wielaard
2022-03-25 11:17 ` [PATCH v2] libebl: recognize FDO Packaging Metadata ELF note Luca Boccassi
2022-03-25 13:39 ` Mark Wielaard
2022-03-25 13:52 ` Luca Boccassi
2022-03-25 14:47 ` Mark Wielaard
2022-03-25 14:55 ` Luca Boccassi
2022-03-26 16:33 ` Mark Wielaard
2022-03-26 16:57 ` Luca Boccassi
2022-03-26 18:19 ` Luca Boccassi
2022-03-28 9:57 ` Mark Wielaard
2022-03-28 10:41 ` Luca Boccassi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220324231438.350551-3-mark@klomp.org \
--to=mark@klomp.org \
--cc=bluca@debian.org \
--cc=elfutils-devel@sourceware.org \
--cc=luca.boccassi@gmail.com \
--cc=luca.boccassi@microsoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).