From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 79F4A3858C52 for ; Mon, 4 Apr 2022 17:03:27 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 79F4A3858C52 Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-626-os3gS_pIPTOJoYqnVetQ9w-1; Mon, 04 Apr 2022 13:03:26 -0400 X-MC-Unique: os3gS_pIPTOJoYqnVetQ9w-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.rdu2.redhat.com [10.11.54.2]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id CBBA02803599; Mon, 4 Apr 2022 17:03:25 +0000 (UTC) Received: from redhat.com (unknown [10.2.16.64]) by smtp.corp.redhat.com (Postfix) with ESMTPS id BC43D40EC001; Mon, 4 Apr 2022 17:03:25 +0000 (UTC) Received: from fche by redhat.com with local (Exim 4.94.2) (envelope-from ) id 1nbQ6u-00029a-Vo; Mon, 04 Apr 2022 13:03:25 -0400 Date: Mon, 4 Apr 2022 13:03:24 -0400 From: "Frank Ch. Eigler" To: Mark Wielaard Cc: elfutils-devel@sourceware.org Subject: Re: patch: debuginfod ipv4-ipv6 dual-stack Message-ID: <20220404170324.GE933@redhat.com> References: <20220403234943.GB933@redhat.com> <998b003028dc3d65339cb6160159d96f31157570.camel@klomp.org> MIME-Version: 1.0 In-Reply-To: <998b003028dc3d65339cb6160159d96f31157570.camel@klomp.org> User-Agent: Mutt/1.12.0 (2019-05-25) X-Scanned-By: MIMEDefang 2.84 on 10.11.54.2 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Spam-Status: No, score=-5.0 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H5, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: elfutils-devel@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Elfutils-devel mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 04 Apr 2022 17:03:28 -0000 Hi - > That IN6_IS_ADDR_V4MAPPED is funny. Is that actually used in practice? Yeah, actually all the time. On a dual-stack socket, an ipv4 connection gets an ipv6 peer-address that renders like ::ffff:1.2.3.4. > Too bad this cannot be merged with conninfo above. > But this calculates less info. Yeah. > > obatched(clog) << "started http server on " > > - << (d4 != NULL ? "IPv4 " : "") > > - << (d6 != NULL ? "IPv6 " : "") > > + << "IPv4 " > > + << "IPv6 " > > << "port=" << http_port << endl; > > This keeps the log output the same, but I wouldn't mind just removing > the IPv4 and IPv6 strings. Yeah, makes sense. OK, will push with that change. - FChE