From: "Dmitry V. Levin" <ldv@altlinux.org>
To: Mark Wielaard <mark@klomp.org>
Cc: "Frank Ch. Eigler" <fche@redhat.com>, elfutils-devel@sourceware.org
Subject: Re: [PATCH] config: Remove unnecessary setting/unsetting of prefix in profiles
Date: Wed, 29 Jun 2022 23:08:58 +0300 [thread overview]
Message-ID: <20220629200857.GA12368@altlinux.org> (raw)
In-Reply-To: <Yrya71faJRnAIGdz@wildebeest.org>
Hi,
On Wed, Jun 29, 2022 at 08:33:19PM +0200, Mark Wielaard wrote:
> Hi Frank,
>
> On Wed, Jun 29, 2022 at 01:29:04PM -0400, Frank Ch. Eigler wrote:
> > > In both profile.csh.in and profile.sh.in we set and then unset
> > > prefix, but never use it.
> >
> > It is used, because the autoconf @sysconfdir@ macro expands to a
> > string like "$prefix/...", which requires the shell variable $prefix
> > to be set.
>
> O, I see. Indeed the default is '${prefix}/etc'. But I never saw that
> because in a package install configure is called with everything
> expanded [*]. Should have tried by hand.
This is not the first time when a patch removing these definitions of
"prefix" variable is proposed. In fact, I applied a similar patch in my
tree last year because I always use --sysconfdir=/etc and "prefix" is a
very generic name so I prefer not to tamper with it in profile scripts.
--
ldv
prev parent reply other threads:[~2022-06-29 20:08 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-29 16:48 Mark Wielaard
2022-06-29 17:29 ` Frank Ch. Eigler
2022-06-29 18:33 ` Mark Wielaard
2022-06-29 20:08 ` Dmitry V. Levin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220629200857.GA12368@altlinux.org \
--to=ldv@altlinux.org \
--cc=elfutils-devel@sourceware.org \
--cc=fche@redhat.com \
--cc=mark@klomp.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).