From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr1-x42b.google.com (mail-wr1-x42b.google.com [IPv6:2a00:1450:4864:20::42b]) by sourceware.org (Postfix) with ESMTPS id 5E9E03858D28 for ; Sat, 6 Aug 2022 08:53:18 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 5E9E03858D28 Received: by mail-wr1-x42b.google.com with SMTP id q30so5523590wra.11 for ; Sat, 06 Aug 2022 01:53:18 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc; bh=66JZQlA28e2yX9t0yFfScCfJ5C4itIG84mjTLwU5j84=; b=0HTXhm8PUiahQmizJxsXAWLYj1BUWS6DGgmwpTgAOJw9rFYV5qb6nYB37E5RDrFovl LpSszB3ojIOb67Lsj4H0OqKqPkduzj1zKJu+BBFgneSvib3FxAcgc3Rt8hnSUQ0Ro3/M BjORVNpH8zWOTco+C9XLVzU7tpzO+Jompf7dxzUktEnHN3phJWKLRS94bU488JXcoX/3 pQ9ZYJdgcOorH/k19F+zYkFcFdiZlYhEmxt6gPpOX4amL6FI7yMhBRllE17eXv4cHtK+ s8VAhx8iABLWr6Dgq2i/yssBdsngd9p1kajTwAacwPQDFOFysyevDJlGWsB7DYo98Cbl Oyhg== X-Gm-Message-State: ACgBeo2PAuWcEbGUmtEJ1XugVG0CNiMXsfciGZx7+mjFaTviN/oXiqua rFUhsVC+/rtN2d915tqYvg8= X-Google-Smtp-Source: AA6agR76vQPgX/nOl07RhExzgdZyQn5Fc5kmH+kRFFpxm0XurvWu6x5Ys+wS8OfeuuUd5pjt8GYz4g== X-Received: by 2002:a5d:4b87:0:b0:21e:ffa6:a3a6 with SMTP id b7-20020a5d4b87000000b0021effa6a3a6mr6179678wrt.418.1659775996995; Sat, 06 Aug 2022 01:53:16 -0700 (PDT) Received: from nz.home (host81-129-83-151.range81-129.btcentralplus.com. [81.129.83.151]) by smtp.gmail.com with ESMTPSA id r1-20020adfe681000000b002216d3aee78sm3858900wrm.86.2022.08.06.01.53.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 06 Aug 2022 01:53:16 -0700 (PDT) Received: by nz.home (Postfix, from userid 1000) id 9B3D46217165D; Sat, 6 Aug 2022 09:53:15 +0100 (BST) From: Sergei Trofimovich To: elfutils-devel@sourceware.org Cc: Sergei Trofimovich Subject: [PATCH] tests: do not fail on zero sized DIEs (binutils-2.39 compatible) Date: Sat, 6 Aug 2022 09:53:10 +0100 Message-Id: <20220806085310.2603348-1-slyich@gmail.com> X-Mailer: git-send-email 2.37.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-9.7 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, RCVD_IN_BARRACUDACENTRAL, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: elfutils-devel@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Elfutils-devel mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 06 Aug 2022 08:53:20 -0000 binutils started producing 0-sized DIEs on functions interspersed by nested sections (".section ...; .previous). This led to run-low_high_pc.sh failure in form of: FAIL: run-low_high_pc.sh ======================== [b] main.c [2d] main [b] ../sysdeps/i386/start.S [26] _start [40] ../sysdeps/x86/abi-note.c [b52] init.c [b8e] static-reloc.c [2dba] _dl_relocate_static_pie [2dd8] ../sysdeps/i386/crti.S [2def] _init lowpc: 8049000, highpc: 8049000lx ../sysdeps/i386/crti.S: [2def] '_init' highpc <= lowpc FAIL run-low_high_pc.sh (exit status: 255) To work it around let's allow lowpc == highpc special case. https://sourceware.org/bugzilla/show_bug.cgi?id=29450 Signed-off-by: Sergei Trofimovich --- tests/ChangeLog | 4 ++++ tests/low_high_pc.c | 3 +++ 2 files changed, 7 insertions(+) diff --git a/tests/ChangeLog b/tests/ChangeLog index 0c6f68ef..8296e0b6 100644 --- a/tests/ChangeLog +++ b/tests/ChangeLog @@ -1,3 +1,7 @@ +2022-08-04 Sergei Trofimovich + + * low_high_pc.c (handle_die): Allow zero sized DIEs for binutils-2.39. + 2022-08-01 Mark Wielaard * run-debuginfod-percent-escape.sh: Add initial scan wait_ready. diff --git a/tests/low_high_pc.c b/tests/low_high_pc.c index cd022b1c..80c83b6d 100644 --- a/tests/low_high_pc.c +++ b/tests/low_high_pc.c @@ -70,6 +70,9 @@ handle_die (Dwarf_Die *die, void *arg) if (dwarf_hasattr (die, DW_AT_low_pc) && dwarf_hasattr (die, DW_AT_high_pc) && highpc <= lowpc + /* gas-2.39 produces zero sized DIEs sometimes: + https://sourceware.org/PR29451. */ + && highpc != lowpc && ! (dwarf_tag (die) == DW_TAG_compile_unit && highpc == lowpc)) { printf("lowpc: %" PRIx64 ", highpc: %" PRIx64 "\n", lowpc, highpc); -- 2.37.1