From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id AB7C23858D1E for ; Wed, 17 Aug 2022 10:58:49 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org AB7C23858D1E Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-3-CpzXNecmOaGzC4oHYsYxMQ-1; Wed, 17 Aug 2022 06:58:47 -0400 X-MC-Unique: CpzXNecmOaGzC4oHYsYxMQ-1 Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 6EDA629DD9A8; Wed, 17 Aug 2022 10:58:47 +0000 (UTC) Received: from redhat.com (unknown [10.2.17.198]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 600DA492C3B; Wed, 17 Aug 2022 10:58:47 +0000 (UTC) Received: from fche by redhat.com with local (Exim 4.94.2) (envelope-from ) id 1oOGl4-0003kt-H6; Wed, 17 Aug 2022 06:58:46 -0400 Date: Wed, 17 Aug 2022 06:58:46 -0400 From: "Frank Ch. Eigler" To: Martin =?utf-8?B?TGnFoWth?= Cc: elfutils-devel@sourceware.org Subject: Re: [PATCH] debuginfod: print filename for "cannot open archive" error Message-ID: <20220817105846.GA4328@redhat.com> References: <1d95d22d-9582-755a-9de1-3f5d8fc3ebe0@suse.cz> MIME-Version: 1.0 In-Reply-To: <1d95d22d-9582-755a-9de1-3f5d8fc3ebe0@suse.cz> User-Agent: Mutt/1.12.0 (2019-05-25) X-Scanned-By: MIMEDefang 2.85 on 10.11.54.10 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Spam-Status: No, score=-9.6 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: elfutils-devel@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Elfutils-devel mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 17 Aug 2022 10:58:51 -0000 Hi - > Report the file that has such a problem so that one can inspect it. > Signed-off-by: Martin Liska The complication with this type of change is that the exception text objects also make it into the prometheus metrics. When file names and such variables show up, they will bifurcate all the affected error metrics into families. Not sure what is the best solution to that. A separate verbose log print to explain the specifics of this error? An extra parameter to the exception object, which is only logged but not passed to prometheus metric naming? Some other way? - FChE