public inbox for
 help / color / mirror / Atom feed
From: "Frank Ch. Eigler" <>
To: "Martin Liška" <>
Subject: Re: [PATCH] debuginfod: fix http_requests_total{type="debuginfo"} when dwz is used
Date: Wed, 17 Aug 2022 07:48:01 -0400	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

Hi -

> When dwarf_extract_source_paths is called, it can call handle_buildid
> when a rpm file used dwz. Ignore such internal request in
> http_requests_total statistics.

Noble goal:

> @@ -1906,7 +1906,7 @@ handle_buildid (MHD_Connection* conn,
>                  const string& buildid /* unsafe */,
>                  string& artifacttype /* unsafe, cleanse on exception/return */,
>                  const string& suffix /* unsafe */,
> -                int *result_fd)
> +                int *result_fd, bool update_metrics = true)

.... but no need for an extra parameter.  When conn==0, we have
an internal request, so can use that as a flag.

- FChE

  reply	other threads:[~2022-08-17 11:48 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-17  7:41 Martin Liška
2022-08-17 11:48 ` Frank Ch. Eigler [this message]
2022-08-17 11:54   ` [PATCH v2] " Martin Liška

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).