From: "Frank Ch. Eigler" <fche@redhat.com>
To: elfutils-devel@sourceware.org
Subject: [patch git] PR28284 - debuginfod x-debuginfod* header processing
Date: Fri, 2 Sep 2022 20:13:04 -0400 [thread overview]
Message-ID: <20220903001304.GA20286@redhat.com> (raw)
Hi -
I had a bit of time to tweak Noah Sanci's PR28284 work, and I believe
it addresses Mark's last set of comments (from a while ago). This
follow-up patch corrects things like case sensitivity, spacing, \r\n
processing, and tweaks documentation.
The gist of it is to add a new client api function
debuginfod_get_headers(), documented to return x-debuginfod* headers
from current or previous fetch requests. debuginfod-find prints those
in -v verbose mode, and debuginfod relays them in federation.
This stuff is an enabler for rgoldber's subsequent
signature-passing/checking code, to which I plan to turn my attention
next.
Please see users/fche/try-pr28284d for this draft of the code. I'd
like to keep it as two separate commits to preserve Noah's id in the
git history, even though that makes it a bit harder to give a final
review.
git diff --stat origin/master...origin/users/fche/try-pr28284d
debuginfod/ChangeLog | 22 ++++++++++++++++++++++
debuginfod/debuginfod-client.c | 24 ++++++++++++++++++------
debuginfod/debuginfod-find.c | 3 +++
debuginfod/debuginfod.cxx | 22 ++++++++++++++++++++++
debuginfod/debuginfod.h.in | 4 ++++
debuginfod/libdebuginfod.map | 3 +++
doc/ChangeLog | 10 ++++++++++
doc/debuginfod_find_debuginfo.3 | 14 ++++++++++++++
doc/debuginfod_get_headers.3 | 2 ++
tests/ChangeLog | 12 ++++++++++++
tests/run-debuginfod-response-headers.sh | 53 +++++++++++++++++++++++++++++++++++++++++++++--------
11 files changed, 155 insertions(+), 14 deletions(-)
- FChE
next reply other threads:[~2022-09-03 0:13 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-03 0:13 Frank Ch. Eigler [this message]
2022-09-06 15:49 ` Mark Wielaard
2022-09-06 16:05 ` Frank Ch. Eigler
2022-09-06 16:42 ` Ryan Goldberg
2022-09-08 11:42 ` Mark Wielaard
2022-09-08 13:45 ` Frank Ch. Eigler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220903001304.GA20286@redhat.com \
--to=fche@redhat.com \
--cc=elfutils-devel@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).