* [OB PATCH] debuginfod-client: Ensure only negative error codes returned.
@ 2022-09-28 14:17 Aaron Merey
0 siblings, 0 replies; only message in thread
From: Aaron Merey @ 2022-09-28 14:17 UTC (permalink / raw)
To: elfutils-devel; +Cc: Aaron Merey
Committing as obvious:
Switch a couple error codes from positive to negative so they aren't
interpreted as file descriptors by the caller.
Signed-off-by: Aaron Merey <amerey@redhat.com>
---
debuginfod/ChangeLog | 5 +++++
debuginfod/debuginfod-client.c | 4 ++--
2 files changed, 7 insertions(+), 2 deletions(-)
diff --git a/debuginfod/ChangeLog b/debuginfod/ChangeLog
index 680720ff..8fb65133 100644
--- a/debuginfod/ChangeLog
+++ b/debuginfod/ChangeLog
@@ -1,3 +1,8 @@
+2022-09-28 Aaron Merey <amerey@redhat.com>
+
+ * debuginfod-client.c (debuginfod_query_server): Switch sign of some
+ error codes from positive to negative.
+
2022-09-08 Frank Ch. Eigler <fche@redhat.com>
* debuginfod-client.c (debuginfod_query_server): Clear
diff --git a/debuginfod/debuginfod-client.c b/debuginfod/debuginfod-client.c
index 28ad04c0..2a14d9d9 100644
--- a/debuginfod/debuginfod-client.c
+++ b/debuginfod/debuginfod-client.c
@@ -1085,7 +1085,7 @@ debuginfod_query_server (debuginfod_client *c,
c->winning_headers = NULL;
if ( maxtime > 0 && clock_gettime(CLOCK_MONOTONIC_RAW, &start_time) == -1)
{
- rc = errno;
+ rc = -errno;
goto out2;
}
long delta = 0;
@@ -1096,7 +1096,7 @@ debuginfod_query_server (debuginfod_client *c,
{
if (clock_gettime(CLOCK_MONOTONIC_RAW, &cur_time) == -1)
{
- rc = errno;
+ rc = -errno;
goto out2;
}
delta = cur_time.tv_sec - start_time.tv_sec;
--
2.37.3
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2022-09-28 14:17 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-09-28 14:17 [OB PATCH] debuginfod-client: Ensure only negative error codes returned Aaron Merey
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).