From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from vmicros1.altlinux.org (vmicros1.altlinux.org [194.107.17.57]) by sourceware.org (Postfix) with ESMTP id 749DF385840C for ; Mon, 24 Oct 2022 11:41:38 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 749DF385840C Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=altlinux.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=altlinux.org Received: from mua.local.altlinux.org (mua.local.altlinux.org [192.168.1.14]) by vmicros1.altlinux.org (Postfix) with ESMTP id 81ADE72C8DC; Mon, 24 Oct 2022 14:41:37 +0300 (MSK) Received: by mua.local.altlinux.org (Postfix, from userid 508) id 72F877CF92B; Mon, 24 Oct 2022 14:41:37 +0300 (MSK) Date: Mon, 24 Oct 2022 14:41:37 +0300 From: "Dmitry V. Levin" To: Martin =?utf-8?B?TGnFoWth?= Cc: elfutils-devel@sourceware.org, Mark Wielaard , Fangrui Song Subject: Re: [PATCH][RFC] readelf: partial support of ZSTD compression Message-ID: <20221024114137.GA19251@altlinux.org> References: <542eb279-d15d-6f17-02c0-c53fd0f33055@suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <542eb279-d15d-6f17-02c0-c53fd0f33055@suse.cz> X-Spam-Status: No, score=-12.5 required=5.0 tests=BAYES_00,GIT_PATCH_0,KAM_DMARC_STATUS,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Mon, Oct 24, 2022 at 01:09:59PM +0200, Martin Liška wrote: [...] > One TODO I see is that: > +libelf_so_LDLIBS = $(libelf_so_DEPS) -lz -lzstd > > should be conditional based on HAVE_ZSTD. But I don't know how to do that? I suppose you're talking about libzstd_LIBS. [...] > diff --git a/m4/zstd.m4 b/m4/zstd.m4 > new file mode 100644 > index 00000000..6da4db68 > --- /dev/null > +++ b/m4/zstd.m4 > @@ -0,0 +1,23 @@ > +dnl Copyright (C) 2022 Free Software Foundation, Inc. > +dnl This file is free software, distributed under the terms of the GNU > +dnl General Public License. As a special exception to the GNU General > +dnl Public License, this file may be distributed as part of a program > +dnl that contains a configuration script generated by Autoconf, under > +dnl the same distribution terms as the rest of that program. > + > +dnl Enable features using the zstd library. > +AC_DEFUN([AC_ZSTD], [ > +AC_ARG_WITH(zstd, > + [AS_HELP_STRING([--with-zstd], [support zstd compressed debug sections (default=auto)])], > + [], [with_zstd=auto]) Where does this code come from? I though the "AC_" prefix is reserved for the GNU Autoconf. Also, looks like it would be more appropriate to call it --enable-zstd rather than --with-zstd. -- ldv