From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from vmicros1.altlinux.org (vmicros1.altlinux.org [194.107.17.57]) by sourceware.org (Postfix) with ESMTP id 072323858421 for ; Mon, 24 Oct 2022 16:48:07 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 072323858421 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=altlinux.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=altlinux.org Received: from mua.local.altlinux.org (mua.local.altlinux.org [192.168.1.14]) by vmicros1.altlinux.org (Postfix) with ESMTP id 64F3B72C8DC; Mon, 24 Oct 2022 19:48:06 +0300 (MSK) Received: by mua.local.altlinux.org (Postfix, from userid 508) id 52A297CF92B; Mon, 24 Oct 2022 19:48:06 +0300 (MSK) Date: Mon, 24 Oct 2022 19:48:06 +0300 From: "Dmitry V. Levin" To: Martin =?utf-8?B?TGnFoWth?= Cc: elfutils-devel@sourceware.org, Mark Wielaard , Fangrui Song Subject: Re: [PATCH][RFC] readelf: partial support of ZSTD compression Message-ID: <20221024164806.GA21412@altlinux.org> References: <542eb279-d15d-6f17-02c0-c53fd0f33055@suse.cz> <20221024114137.GA19251@altlinux.org> <0375dd0c-2410-d1ca-8ce7-41293e8e2fa2@suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <0375dd0c-2410-d1ca-8ce7-41293e8e2fa2@suse.cz> X-Spam-Status: No, score=-6.4 required=5.0 tests=BAYES_00,KAM_DMARC_STATUS,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Mon, Oct 24, 2022 at 02:17:17PM +0200, Martin Liška wrote: > On 10/24/22 13:41, Dmitry V. Levin wrote: > > On Mon, Oct 24, 2022 at 01:09:59PM +0200, Martin Liška wrote: > > [...] > >> One TODO I see is that: > >> +libelf_so_LDLIBS = $(libelf_so_DEPS) -lz -lzstd > >> > >> should be conditional based on HAVE_ZSTD. But I don't know how to do that? > > > > I suppose you're talking about libzstd_LIBS. > > Hm, can't see it after autoreconf -fi and ./configure. That's because you do PKG_CHECK_MODULES(ZSTD, [libzstd], ...) and this defines ZSTD_CFLAGS and ZSTD_LIBS instead of libzstd_CFLAGS and libzstd_LIBS because PKG_CHECK_MODULES() uses its first argument as the prefix for these variables. -- ldv