public inbox for
 help / color / mirror / Atom feed
From: "Frank Ch. Eigler" <>
To: Aaron Merey <>
Subject: Re: [PATCH] debuginfod: Support queries for ELF/DWARF sections
Date: Mon, 24 Oct 2022 14:38:09 -0400	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

Hi -

Generally looks fine, thanks a lot.
A few nits:

- use of write(2) to put files onto disk is not quite right; write(2) can
  be partial, so you need a loop (or a macro wrapping a loop)

- not sure I understand why the code worries about dots in or not in
  section names.  Why not just pass them verbatim throughout the code
  base, and not worry about whether or not there's a dot?  Does the
  ELF standard even require a dot?

- not sure whether/why the I queries require a new _query_i view, as
  opposed to running the _query_d & _query_e views union'd together.
  I see an ORDER BY that's different here but not sure why bother;
  if anything, the server could prefer one or the other type, based
  on the same section-name heuristic as the client

- don't really see a need for the X-DEBUGINFOD-SECTION response
  header, which simply echoes back the very same parameter the client
  just requested; the other X-DEBUGINFOD-* headers are novel metadata

- re. verbose logging in the section vs non-section case, suggest
  just keeping the code simple (even if it makes the logs more verbose),
  i.e., not duplicating if (...) clog << STUFF else clog << STUFF;
  no biggie tho

- the webapi docs in debuginfod.8 should document the new query type

Otherwise lgtm.  Lots of nice work.

- FChE

  reply	other threads:[~2022-10-24 18:38 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-21  0:06 [PATCH v2] " Aaron Merey
2022-10-22  0:09 ` [PATCH] " Aaron Merey
2022-10-24 18:38   ` Frank Ch. Eigler [this message]
2022-10-26 14:57     ` Mark Wielaard
2022-10-26 15:28       ` Frank Ch. Eigler
2022-10-26 17:57       ` Aaron Merey
2022-10-26 15:25     ` Mark Wielaard
2022-10-26 17:55     ` Aaron Merey
  -- strict thread matches above, loose matches on Subject: below --
2022-09-28  2:10 Aaron Merey
2022-09-28 14:28 ` Frank Ch. Eigler
2022-09-28 18:20   ` Aaron Merey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).