public inbox for
 help / color / mirror / Atom feed
From: Mark Wielaard <>
Cc: Mark Wielaard <>
Subject: [COMMITTED] debuginfod: Mark extract_section function static
Date: Wed,  2 Nov 2022 18:03:13 +0100	[thread overview]
Message-ID: <> (raw)

The extract_section function in debuginfod-client.c is an internal
function and should not be exported. Mark it as static.

Signed-off-by: Mark Wielaard <>
 debuginfod/ChangeLog           | 4 ++++
 debuginfod/debuginfod-client.c | 2 +-
 2 files changed, 5 insertions(+), 1 deletion(-)

diff --git a/debuginfod/ChangeLog b/debuginfod/ChangeLog
index 50668e61..1efa080f 100644
--- a/debuginfod/ChangeLog
+++ b/debuginfod/ChangeLog
@@ -1,3 +1,7 @@
+2022-11-02  Mark Wielaard  <>
+	* debuginfod-client.c (extract_section): Mark static.
 2022-11-01  Aaron Merey  <>
 	* debuginfod-client.c (path_escape): Add early return.
diff --git a/debuginfod/debuginfod-client.c b/debuginfod/debuginfod-client.c
index 0c4a00cf..f48e32cc 100644
--- a/debuginfod/debuginfod-client.c
+++ b/debuginfod/debuginfod-client.c
@@ -621,7 +621,7 @@ path_escape (const char *src, char *dest)
    section name was not found.  -EEXIST indicates that the section was
    found but had type SHT_NOBITS.  */
+static int
 extract_section (int fd, const char *section, char *fd_path, char **usr_path)
   elf_version (EV_CURRENT);

                 reply	other threads:[~2022-11-02 17:03 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).