public inbox for elfutils@sourceware.org
 help / color / mirror / Atom feed
* [PATCH] backends: sparc uses NONE relocation type in ET_EXEC and ET_DYN files
@ 2023-01-19 22:11 Mark Wielaard
  2023-01-19 22:17 ` Jose E. Marchesi
  0 siblings, 1 reply; 3+ messages in thread
From: Mark Wielaard @ 2023-01-19 22:11 UTC (permalink / raw)
  To: elfutils-devel; +Cc: Jose E . Marchesi, Sam James, Mark Wielaard

Using the NONE relocation doesn't do anything, but is harmless.

This fixes several (self) tests on sparc that use elflint to
check files are valid ELF.

Signed-off-by: Mark Wielaard <mark@klomp.org>
---
 backends/ChangeLog       | 4 ++++
 backends/sparc_reloc.def | 2 +-
 2 files changed, 5 insertions(+), 1 deletion(-)

diff --git a/backends/ChangeLog b/backends/ChangeLog
index f28ab89b..40ec7c0c 100644
--- a/backends/ChangeLog
+++ b/backends/ChangeLog
@@ -1,3 +1,7 @@
+2023-01-19  Mark Wielaard  <mark@klomp.org>
+
+	* sparc_reloc.def (NONE): Add EXEC and DYN.
+
 2022-12-21  Shahab Vahedi  <shahab@synopsys.email>
 
 	* Makefile.am (modules): Add arc.
diff --git a/backends/sparc_reloc.def b/backends/sparc_reloc.def
index 7cd5ce96..f0eeb5c6 100644
--- a/backends/sparc_reloc.def
+++ b/backends/sparc_reloc.def
@@ -28,7 +28,7 @@
 
 /* 	    NAME,		REL|EXEC|DYN	*/
 
-RELOC_TYPE (NONE,               REL)
+RELOC_TYPE (NONE,               REL|EXEC|DYN)
 RELOC_TYPE (8,                  REL)
 RELOC_TYPE (16,                 REL)
 RELOC_TYPE (32,                 REL|DYN)
-- 
2.31.1


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] backends: sparc uses NONE relocation type in ET_EXEC and ET_DYN files
  2023-01-19 22:11 [PATCH] backends: sparc uses NONE relocation type in ET_EXEC and ET_DYN files Mark Wielaard
@ 2023-01-19 22:17 ` Jose E. Marchesi
  2023-01-19 22:44   ` Mark Wielaard
  0 siblings, 1 reply; 3+ messages in thread
From: Jose E. Marchesi @ 2023-01-19 22:17 UTC (permalink / raw)
  To: Mark Wielaard; +Cc: elfutils-devel, Sam James


> Using the NONE relocation doesn't do anything, but is harmless.
>
> This fixes several (self) tests on sparc that use elflint to
> check files are valid ELF.

FWIW looks good to me.

>
> Signed-off-by: Mark Wielaard <mark@klomp.org>
> ---
>  backends/ChangeLog       | 4 ++++
>  backends/sparc_reloc.def | 2 +-
>  2 files changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/backends/ChangeLog b/backends/ChangeLog
> index f28ab89b..40ec7c0c 100644
> --- a/backends/ChangeLog
> +++ b/backends/ChangeLog
> @@ -1,3 +1,7 @@
> +2023-01-19  Mark Wielaard  <mark@klomp.org>
> +
> +	* sparc_reloc.def (NONE): Add EXEC and DYN.
> +
>  2022-12-21  Shahab Vahedi  <shahab@synopsys.email>
>  
>  	* Makefile.am (modules): Add arc.
> diff --git a/backends/sparc_reloc.def b/backends/sparc_reloc.def
> index 7cd5ce96..f0eeb5c6 100644
> --- a/backends/sparc_reloc.def
> +++ b/backends/sparc_reloc.def
> @@ -28,7 +28,7 @@
>  
>  /* 	    NAME,		REL|EXEC|DYN	*/
>  
> -RELOC_TYPE (NONE,               REL)
> +RELOC_TYPE (NONE,               REL|EXEC|DYN)
>  RELOC_TYPE (8,                  REL)
>  RELOC_TYPE (16,                 REL)
>  RELOC_TYPE (32,                 REL|DYN)

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] backends: sparc uses NONE relocation type in ET_EXEC and ET_DYN files
  2023-01-19 22:17 ` Jose E. Marchesi
@ 2023-01-19 22:44   ` Mark Wielaard
  0 siblings, 0 replies; 3+ messages in thread
From: Mark Wielaard @ 2023-01-19 22:44 UTC (permalink / raw)
  To: Jose E. Marchesi; +Cc: elfutils-devel, Sam James

Hi Jose,

On Thu, Jan 19, 2023 at 11:17:13PM +0100, Jose E. Marchesi wrote:
> > Using the NONE relocation doesn't do anything, but is harmless.
> >
> > This fixes several (self) tests on sparc that use elflint to
> > check files are valid ELF.
> 
> FWIW looks good to me.

Thanks, pushed.

Cheers,

Mark

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2023-01-19 22:44 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-01-19 22:11 [PATCH] backends: sparc uses NONE relocation type in ET_EXEC and ET_DYN files Mark Wielaard
2023-01-19 22:17 ` Jose E. Marchesi
2023-01-19 22:44   ` Mark Wielaard

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).