From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gnu.wildebeest.org (gnu.wildebeest.org [45.83.234.184]) by sourceware.org (Postfix) with ESMTPS id 423543858D28 for ; Thu, 26 Jan 2023 20:48:41 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 423543858D28 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=klomp.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=klomp.org Received: by gnu.wildebeest.org (Postfix, from userid 1000) id A0797302BBEC; Thu, 26 Jan 2023 21:48:39 +0100 (CET) Date: Thu, 26 Jan 2023 21:48:39 +0100 From: Mark Wielaard To: vvvvvv@google.com Cc: elfutils-devel@sourceware.org, kernel-team@android.com, maennich@google.com Subject: Re: [PATCH] libdwfl: add check for elf_memory return value Message-ID: <20230126204839.GB2781@gnu.wildebeest.org> References: <20230125141657.881588-1-vvvvvv@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230125141657.881588-1-vvvvvv@google.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-Spam-Status: No, score=-3031.8 required=5.0 tests=BAYES_00,JMQ_SPF_NEUTRAL,KAM_DMARC_STATUS,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi Aleksei, On Wed, Jan 25, 2023 at 02:16:57PM +0000, Aleksei Vetrov via Elfutils-devel wrote: > From: Aleksei Vetrov > > elf_memory call in __libdw_open_elf_memory can return NULL. It was not > checked and led to the null pointer dereference. Looks good. Pushed. Thanks for finding this, Cheers, Mark