From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gnu.wildebeest.org (gnu.wildebeest.org [45.83.234.184]) by sourceware.org (Postfix) with ESMTPS id B630F3858D1E for ; Mon, 30 Jan 2023 21:04:32 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org B630F3858D1E Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=klomp.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=klomp.org Received: by gnu.wildebeest.org (Postfix, from userid 1000) id 70CFC30067B1; Mon, 30 Jan 2023 22:04:31 +0100 (CET) Date: Mon, 30 Jan 2023 22:04:31 +0100 From: Mark Wielaard To: elfutils-devel@sourceware.org Subject: Re: [PATCH] addr2line: -C should not try to handle optional (ignored) argument Message-ID: <20230130210431.GC11361@gnu.wildebeest.org> References: <20230123091128.687801-1-mark@klomp.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230123091128.687801-1-mark@klomp.org> User-Agent: Mutt/1.5.21 (2010-09-15) X-Spam-Status: No, score=-3031.7 required=5.0 tests=BAYES_00,JMQ_SPF_NEUTRAL,KAM_DMARC_STATUS,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi, On Mon, Jan 23, 2023 at 10:11:28AM +0100, Mark Wielaard wrote: > The --demangle option takes an option (ignored) argument. Since -C > is the short option of --demangle it also takes that optional > argument. But that means that something like -Cfi is like -C got > fi as argument, while the user expects -Cfi to be like -C -f -i. > > Separate the --demangle and -C options. --demangle still takes > an optional (ignored) argument, but -C doesn't take any arguments > so -Cfi acts the same as -fiC. > > Also fix --target, -b, so that it is properly ignored (and not > accidentially enables demangling). Pushed. Cheers, Mark