From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gnu.wildebeest.org (gnu.wildebeest.org [45.83.234.184]) by sourceware.org (Postfix) with ESMTPS id ACE91385840F for ; Fri, 24 Feb 2023 11:51:26 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org ACE91385840F Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=klomp.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=klomp.org Received: by gnu.wildebeest.org (Postfix, from userid 1000) id D618A30067D6; Fri, 24 Feb 2023 12:51:25 +0100 (CET) Date: Fri, 24 Feb 2023 12:51:25 +0100 From: Mark Wielaard To: "Guillermo E. Martinez" Cc: elfutils-devel@sourceware.org Subject: Re: [PATCH v3] strip: keep .ctf section in stripped file Message-ID: <20230224115125.GD9039@gnu.wildebeest.org> References: <20220601155527.2192182-1-guillermo.e.martinez@oracle.com> <20230223184237.240615-1-guillermo.e.martinez@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230223184237.240615-1-guillermo.e.martinez@oracle.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-Spam-Status: No, score=-3031.1 required=5.0 tests=BAYES_00,JMQ_SPF_NEUTRAL,KAM_DMARC_STATUS,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi Guillermo, On Thu, Feb 23, 2023 at 12:42:37PM -0600, Guillermo E. Martinez via Elfutils-devel wrote: > This is the third version of the patch to avoid remove the CTF section in > stripped files. Changes from v2: > > - Rebased from master. > > Please let me know your thoughts. > > CTF debug format was designed to be present in stripped files, so > this section should not be removed, so a new --remove-ctf option > is added to indicate explicitly that .ctf section will be stripped > out from binary file. Since the way to recognize a CTF section is by name ".ctf" does it really need a new option? eu-strip already has: --keep-section=SECTION Keep the named section. SECTION is an extended wildcard pattern. May be given more than once. -R, --remove-section=SECTION Remove the named section. SECTION is an extended wildcard pattern. May be given more than once. Only non-allocated sections can be removed. Do you really need a new option? Or could you use an explicit --keep-section=.ctf and/or --remove-section=.ctf ? Thanks, Mark