From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) by sourceware.org (Postfix) with ESMTPS id 86AD13858C2C for ; Tue, 7 Mar 2023 20:48:22 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 86AD13858C2C Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=oracle.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=oracle.com Received: from pps.filterd (m0333520.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 327JwnJF018499; Tue, 7 Mar 2023 20:48:04 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=date : from : to : cc : subject : message-id : references : content-type : in-reply-to : mime-version; s=corp-2022-7-12; bh=BVV4mf4RzdsQvO3OKDsjGB50BDS0jTqA3ws+VqkOerI=; b=VeOxwRL7lIiHUcwXssumghz2wtXlWOs8K6HWQe9XIccDsVhiUzjg/qysC80scohedko9 LlIFsch1eA8Epwbrc+Y3bQbI+4ewsFwOpJ5ZfQc0llo6b+70gJ9bdnrhMXLqU0++OMXo 2iIlVsT59FcO9qGK4UZETthiw38+SvQam9nIfFaS1lgyLLoF57CEyphGDDdeMJCIITBK N3mFB2ArYp/c0afhhbhRd7K1504qg5Qd/T1kAtyKA4hPylMeUJsYHn3x05vb3mJoFtam pKAJEEblXiSeyskuew5jLG2ms33Irlkj1Xox3XQWN1UGDJggY7sKi/48dh+RG+PBYXoM HQ== Received: from iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta01.appoci.oracle.com [130.35.100.223]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3p415hxnne-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 07 Mar 2023 20:48:04 +0000 Received: from pps.filterd (iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com (8.17.1.5/8.17.1.5) with ESMTP id 327JEvFL011181; Tue, 7 Mar 2023 20:48:03 GMT Received: from nam11-dm6-obe.outbound.protection.outlook.com (mail-dm6nam11lp2177.outbound.protection.outlook.com [104.47.57.177]) by iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com (PPS) with ESMTPS id 3p4u2jb9bg-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 07 Mar 2023 20:48:03 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=MLHPJ8Teni1167nYOWW6sA635ChyWqi4cKwhQXC2KUKlh4/lEcZ+E2p4oZGZ7KovSmP1fzTwK25M+qIJgOCqNVOBSx15su6fW7ZdSKhYDsunI3z9WiGSKv/iC9w7nR009S2pGbCvWrAWbUMbinAM4zCafqGa9MBmvZWgztVxnWSrZloxCNpXo9BeGrof2s5OISO3SSsjyWQ9j28fh5izOlAI872TJtcHrBsjF6+xv/IbC8/v0Q7QkuBe2pAP119fCQlbW4163joEbtpeivIy41p5bJXjwDLI/Fu9UPlvq2VpBc7OJU1qVFTNNy+LvccGCr8gW2PwDywkP0n45GB+bA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=BVV4mf4RzdsQvO3OKDsjGB50BDS0jTqA3ws+VqkOerI=; b=mtyznjLWV05eL2MKIhqJwvXO9PcTZrISYUmPUt2wXpkqEHCLeTxN69DXaXnz1e7OsMSPdCdc0T7FmPy6G7aN6cBNUMrqBmLLCgoOONDbz0vF9ZATDX8+o1VpFdzq0YSjOLcszKhmK5piwpBdUJT7CNySAso9n9xvYlRp71xbyD5I4UX4Tplw4aexDpl9L5eFen8E1kZaAmBEmMCnZzZ2kqOqaEfni1AiksXsoQcjt7xxE9sZkuylYEGGZcRKCmn+hGsorm2G9hYV8+uMqymWiwx2XbcmB1wlS0gICMd857be/PHTevbVaP3uOGQDFiuqwBTTyEdhRBzVO2Ovoq9rPQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=BVV4mf4RzdsQvO3OKDsjGB50BDS0jTqA3ws+VqkOerI=; b=psf46cKvQipJmKzpaOczBb2ptGMcHkW9l+X+zUc1xwYCdDkRs/6fnaW+E8Gz4IPSqG4zKYz7Wsf7UDxW0xUu4Zui9bRhRbioePgCmwqVHYUOl828INfDuPIQ1RM8eafJf/CMSL7SCqihw2LizQPAHFw0XWlzHlOJI4q3mTEqlEE= Received: from MWHPR10MB1407.namprd10.prod.outlook.com (2603:10b6:300:23::20) by CO1PR10MB4804.namprd10.prod.outlook.com (2603:10b6:303:90::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6156.29; Tue, 7 Mar 2023 20:48:01 +0000 Received: from MWHPR10MB1407.namprd10.prod.outlook.com ([fe80::480f:b0b1:2e28:546e]) by MWHPR10MB1407.namprd10.prod.outlook.com ([fe80::480f:b0b1:2e28:546e%7]) with mapi id 15.20.6156.028; Tue, 7 Mar 2023 20:48:01 +0000 Date: Tue, 7 Mar 2023 14:47:57 -0600 From: "Guillermo E. Martinez" To: Mark Wielaard Cc: Nick Clifton , elfutils-devel@sourceware.org Subject: Re: [PATCH v3] strip: keep .ctf section in stripped file Message-ID: <20230307204757.iroxwejwyvupaz2v@kamehouse> References: <20230224115125.GD9039@gnu.wildebeest.org> <20230224164838.lyfxsjbcpttxdsaf@kamehouse> <492387583758712a4f5f1f2e2646a3ba6a7a23f1.camel@klomp.org> <8367d8ae-670d-b614-d922-211dcae11250@redhat.com> <0f9fdbd9eaaa8a8e42b426d86a5aa977eef2d8e4.camel@klomp.org> <20230303024058.42stfebtruwj4t3e@kamehouse> <8f58e4ca-16c9-4401-1985-262db0299cbb@redhat.com> <20230304140044.gp5fvjufvomr2vv3@kamehouse> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-ClientProxiedBy: BLAPR03CA0104.namprd03.prod.outlook.com (2603:10b6:208:32a::19) To MWHPR10MB1407.namprd10.prod.outlook.com (2603:10b6:300:23::20) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MWHPR10MB1407:EE_|CO1PR10MB4804:EE_ X-MS-Office365-Filtering-Correlation-Id: 6476a02b-240c-4055-2dd2-08db1f4d3dfb X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: E3RHI5G6cnqg41/IQFPekhU3vYmCWykr6OTy7HnKrxopzUiTXNGVCBX5V3zAF61+VqSJF5Fnw/e5340HirKCfFL03rNKikUCMiWeKe5LF3ZUOXs9oIsyVKNGMYgNsx+cykz/BwLQiwr0MeNK4SaBdhADqqa/dB8h5mTwKyTdcLSf4Ra3ZnfNJJbHU3eAPZ//fozu/wN9P84NplqbjnuhAijvhTNRM3Z9XMN1Ljmj2Ekk6xKZ4dCxlFtcbHW6gqyIBsyWkZconhTQMd5vTgki5kk/Xaoo9w/SHvNYGI6fawcB0pyWoSEIc/rKrGU6+x4xacAWQ/kg1mLFmG8XcKYw3eUB3m6/Dn0xt833dVddN3QslS7QdjaK47co+J3EyMnm0fTVBOVShESVtRnzZJ9s4BNuBVXww7eb7ICvvsLbf3B0/lz/qp4CuwzX9+XLOF9SdqDQZGpV+fcsw50E3dp9vkSsCPtchnuzlpbS7zAqKBjIMM/ur7gaiK/dY6wmhoAzlG5ql9YiFNsgZg5bujSY8uo2tqozFazyEl74bpG16cJwwihHTiYq/9MMMv0zVPEsqg7KB32koEWweb/mi/p8mmkxWWexf9gfPe5S34pvY4bwBoc2mycAcSOf1PtHdfKrK8BveQbT1wZig3fEk0IwwNJ0ixLeBpJIK8hhH3K5CfyP94Bqw/fDrjUGGkFgYEjC X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MWHPR10MB1407.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(7916004)(136003)(376002)(39860400002)(366004)(346002)(396003)(451199018)(66946007)(66476007)(66556008)(8676002)(6486002)(478600001)(316002)(41300700001)(6916009)(4326008)(5660300002)(86362001)(6506007)(1076003)(26005)(9686003)(6512007)(186003)(33716001)(2906002)(38100700002)(8936002)(6666004)(142923001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?S5DRZ7WeXJPDI7uujWYCVNCJJUrYJIN7Ap5d4kkXzHuQCzETq+jdc8kbP5u5?= =?us-ascii?Q?o6tE9f66DTiJR48mGzv/yDEIXtdN/cCV0tSlAQaBvZu0LugKO8x20IYHCjlX?= =?us-ascii?Q?7b/DEFQ0zbaqYIqdsv43BSDtHzWyqwl27hv5jRjS13rEtDhmSUj6zfsw5VIg?= =?us-ascii?Q?0Tc7uTRHQhaUy51ZJxeVToD9JEEb3uiZz/K+RRjzn4qd5uFt87sHWzIp1t4U?= =?us-ascii?Q?cAizp0jBlhAnQIma71KogrQKw5CvQOZ4xREeVOICUERpXjm+w9p7y7pT7Thf?= =?us-ascii?Q?QIqLfjEBjZKtLyj2lOurMyXcJkwRxC1E4AB3THdBu7vF/ufS1/y0PHrtS4pd?= =?us-ascii?Q?J3ltJkomoUpgbHqd8WidVadOlkLEGLTv6Mq4GKFEvoc/aKq6dN/4uvBK65bR?= =?us-ascii?Q?xvDoOsDqooM4PrYnYn/cbNTcs5bbucx00TZyfl+Q9FDzIuuzJL2NmrYbJGtS?= =?us-ascii?Q?6ALHP4Q1xw24XBE3QIShTTndQHUSMpfzMcRxavkmVC9rDYFQjoji0MT1Xlaa?= =?us-ascii?Q?bDjeHgDch1PTk4iD0HQmGjAYRpBU314c9UicD2r61MMoyXFNm5eR8w5lmLpv?= =?us-ascii?Q?wCT4UcF6jBqtgnWccok7orUhqiIdhYGr0vhv3ELoSBX3Ph0B4hTKmcJOWtHq?= =?us-ascii?Q?YbnoTqjx8ByA5JsncHrO8xIFe8Ypd+grVtr8Oa+keEQfKpR4K8X16L7PzMUy?= =?us-ascii?Q?VEWRAedb+WvY4C14LjJ5BqwJWLAEyGvXa2HQQgco8qwh6Vy6LNavoncl8Fwo?= =?us-ascii?Q?FGt2mxnhO+YltzKM+OP4mM/fvuqMOz6+HF7XEdBsEtk48y45wHs6HWd8iVki?= =?us-ascii?Q?AkJFN60WZGLYN9bet4vzEZcj1D68uGwFLSdh1oUEEoZ7b0y1Bdio6GJJWXLM?= =?us-ascii?Q?hfYkT35M8+i3JuJOeTHolHoOLtfBb10CtYEQUFO6gfD2ztCWXA5jP9WzegVo?= =?us-ascii?Q?VQnNioXr66H2SN8sx8Dz47OiaU+bEkP42spLlD1oa4vE6eXNezAcNz2ueVLC?= =?us-ascii?Q?JLJ8TJj+lM/VW7S5H/8KSZJJu2MqjmL1Z1s12iSfF3Vkuw9QROujgai3F/R/?= =?us-ascii?Q?qGQ8nECRTaFsOSmZVbQjCOljA57TThtWR5uRJfswSLMHoY6O/nuyAFSfBGr4?= =?us-ascii?Q?lj8mik2AANpWaEXq53EpPPXSYxxJmexSW+Mr5S23EGwK16abRxcOaOKEBQ/8?= =?us-ascii?Q?GoewLFHAb6qoc4UT3ByBwqtbA+Ti/j51LsTI2Rl5bTIShzSqMAK/Zj9nA2zl?= =?us-ascii?Q?JGBLzU+5Ch2yfQAtyW+VzrgMItsKQV+T4xf1VW4N9xV7mEHkl7uPxWh0lTWl?= =?us-ascii?Q?nhPDclXVUS4aZK42K+iIbpnnnFDF1OYjO6ASuvYso4H+p/XfGh6KuyX4oJ8f?= =?us-ascii?Q?rKpgrUGdBD92f7cravlinR+UDKfdRbsyflYlBQC3C+f6w3sHDv2BQ+YntrmR?= =?us-ascii?Q?sksXNob4LNqHpRS7TLzWylqRKvQj71JkApbPFaObiq03nR6kStgdsUPo3UnL?= =?us-ascii?Q?lcSrqrSkDF/GiKSPhZZ8XCxWZRE1+K358Ib+Zf6B1VJHCM2Q/XyCmMxAfi8C?= =?us-ascii?Q?me4PSWAxNrPgCdj3ut/AllSjWnUM29gx6upyMeo7qNonEwqkFDtM4cO3+UA/?= =?us-ascii?Q?lJXxpRHd3VaWDpELlszpPMU=3D?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: kjr9osDZeBLuqK37zBG4oD14n/SwMant4etSBgjNpBa+tq0as/N8T3Dw8UWo7AUNJribChJBomVsStwfrZcDQLhv7fmD6bX/cw4l+nmvnQQ+ueMwBMO9K+OlOaUJ5Gpg8wBNOdK4yQjdSEb4O51pDhku7w7YbG/Wz/p+wA5Bby20Asagj46jZj5yHTmg5HNNgjUP1br7P55kMukBb4hCgVXGa1ZWuDFnI7mDi17JOx1nOoMSInMNTI6LnuEpnC2vn4cqKRXikN/EGChYyx3en+0HE7QAQUnq90yNnUl7lO1Pm7ZOtCrux+wHrFyacS8ByEzV3etUark1T7EP9OBQpzYCCoSDLJ0DF//zh5iZpZ91knBTC+TReZBF7pOjSO+zTG8haMsYeImrwxaXvwe4qF+rqZBvfsyJvVm3T8JtNdNSGrhh7N0p29fdWgBln7fbu2yCICZsNh9+tsvHRCz9W24TzQN1rroENN7q61/KathhCOx8Us/Oaw4KWjuQD2jKd3I+M6An6SsM7udDhcet77G12aMbnojK6o5GYHaa49McnlpaP4lXT6mV6ZS1S2+k1DSSWRPm8iNNiYw7nmpejuRf4XN67XyEaGPDQWaO1QwBYyvgF0IxROS2GfJVu1MCr1j/ZqdtYs67EvzVZpt2/ryH9/mFv8/GvzB9QTKJUJKya0rh8xW9ZFi90bUjVDY5MAl6s0jzx22BLSgVKhz7yJZ72qxYAInw5cBCycGci00dQiMIxbf9n4Gy5Xmgjbixy/rIG+xj2BQtY5SZljz4oOiwDoRFcTV4+01b3sVgzrSmG5UNj2ANT1RqZJO/iZ3B X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6476a02b-240c-4055-2dd2-08db1f4d3dfb X-MS-Exchange-CrossTenant-AuthSource: MWHPR10MB1407.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Mar 2023 20:48:01.8215 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Z6pNhaU6DXAtoEoFEIQJPK+KVSavoyx6ggMB3fB6ZBYlOS4MEJKcsispuqf/wvD6LEXgz7WNxG3nrL4D+TX8WraZNCHZwAtnwBjS1kay0cE= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR10MB4804 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.219,Aquarius:18.0.942,Hydra:6.0.573,FMLib:17.11.170.22 definitions=2023-03-07_16,2023-03-07_01,2023-02-09_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 suspectscore=0 bulkscore=0 phishscore=0 spamscore=0 mlxlogscore=676 mlxscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2212070000 definitions=main-2303070184 X-Proofpoint-GUID: T-Y_z4t1Xff3MYZm-grMj7JlOvD6zNbD X-Proofpoint-ORIG-GUID: T-Y_z4t1Xff3MYZm-grMj7JlOvD6zNbD X-Spam-Status: No, score=-6.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Tue, Mar 07, 2023 at 03:50:01PM +0100, Mark Wielaard wrote: > Hi Nick, Hi Guillermo, > Hi Mark, > On Sat, 2023-03-04 at 08:00 -0600, Guillermo E. Martinez wrote: > > Hello, > > > > On Fri, Mar 03, 2023 at 12:24:19PM +0000, Nick Clifton wrote: > > > Hi Mark, > > > > > > > > > I am mainly wondering why binutils strip already seems to keep ".ctf" > > > > > > sections (even without -g). > > > > > > > Right. But I am wondering how that mechanism works with binutils strip. > > > > Apparently we do something different in eu-strip which makes it > > > > necessary to add a --keep-ctf option based on the section name. It > > > > would be good if we figured out how/what we can do to keep the > > > > different strip utilities in sync. > > > > > > I think that the function that does this is "is_strip_section_1" in > > > > That's right, this function decided whether the section will be striped > > out by default, if it has set `SEC_DEBUGGING' in BFD section flags then > > section is removed by the default. For `.ctf' this flag is not set > > because in `_bfd_elf_make_section_from_shdr' when BFD sections are > > building it uses the section's name: ".debug", ".gnu.debuglto_.debug_", > > ".gnu.linkonce.wi.", ".zdebug", "lines", ".stab", etc, to set > > `SEC_DEBUGGING' flag. > > > > > binutils/objcopy.c. If an input section has the BSF_DEBUGGING flag > > > set (an internal flag to he BFD library, but basically it should be > > > set for all debug sections, including .ctf sections I think), then > > > the basic decision is to keep the section unless -g is used. > > OK, that is interesting. So given the .ctf section is NOT marked as > SEC_DEBUGGING binutils strip basically never strips it. > > While eu-strip does strip it by default (since it is a non-loadable > PROGBITS section), but keeps it with -g (which only strips the > explicitly named .debug sections). > > But both binutils strip and eu-strip do have --keep-section=.ctf which > would explicitly keep it even without -g, and both have --remove- > section=.ctf which always removes the section. > > So binutils strip and eu-strip aren't totally identical with the > default flags, but with --keep-section=.ctf and --remove-section=.ctf > they seem to do the same thing. > > So I am not sure we really need a --keep-ctf flag for eu-strip (unless > we also get it for binutils strip). My preference would be to just > recommend a user use --keep-section=.ctf or --remove-section=.ctf to > indicate what they want. > Oh, I see. My first motivation to add `--keep-ctf' in `eu-strip' is because it's used by `find-debuginfo.sh' script to build the debug RPM packages: `eu-strip --remove-comment $r $g ${keep_remove_args} -f "$1" "$2" || exit' So, `eu-strip' removes `.ctf' section by default. In this case I'll prepare a patch updating `find-debuginfo.sh' to add `--keep-section=.ctf' to `eu-strip' to preserve such section. Thanks for your comments! guillermo